Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 10690137: Fix stats counters (Closed)

Created:
8 years, 5 months ago by jochen (gone - plz use gerrit)
Modified:
8 years, 5 months ago
Reviewers:
jam, Evan Stade
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, arv (Not doing code reviews), jam, danno
Visibility:
Public.

Description

Fix stats counters - intialize the V8 callbacks first thing, otherwise, the counters disable themselves - don't use inline event handlers in the presence of a CSP - on linux, the child processes need to use the parent's parent pid to derive the table name (the parent is the zygote, the parent's parent is the browser) BUG=none TEST=run chrome with --enable-stats-table, you should see lots of V8 stats, and you should be able to filter for e.g. V8 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=146305

Patch Set 1 #

Total comments: 1

Patch Set 2 : update #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -10 lines) Patch
M chrome/browser/resources/about_stats.html View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/resources/about_stats.js View 3 chunks +6 lines, -3 lines 0 comments Download
M content/app/content_main_runner.cc View 1 1 chunk +5 lines, -2 lines 0 comments Download
M content/renderer/render_thread_impl.cc View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
jochen (gone - plz use gerrit)
plz review John: content/ Evan: chrome/browser/resources
8 years, 5 months ago (2012-07-11 15:11:42 UTC) #1
jochen (gone - plz use gerrit)
http://codereview.chromium.org/10690137/diff/1/content/renderer/render_thread_impl.cc File content/renderer/render_thread_impl.cc (right): http://codereview.chromium.org/10690137/diff/1/content/renderer/render_thread_impl.cc#newcode188 content/renderer/render_thread_impl.cc:188: v8::V8::SetCounterFunction(base::StatsTable::FindLocation); V8 counters only try once to lookup themselves ...
8 years, 5 months ago (2012-07-11 15:13:16 UTC) #2
jochen (gone - plz use gerrit)
figured out the reason why it doesn't work, so this patch fixes it
8 years, 5 months ago (2012-07-11 15:34:13 UTC) #3
jochen (gone - plz use gerrit)
danno, fyi
8 years, 5 months ago (2012-07-11 15:35:06 UTC) #4
jam
lgtm
8 years, 5 months ago (2012-07-11 15:53:50 UTC) #5
Evan Stade
resources/ lgtm
8 years, 5 months ago (2012-07-12 01:37:55 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jochen@chromium.org/10690137/5001
8 years, 5 months ago (2012-07-12 07:29:57 UTC) #7
commit-bot: I haz the power
8 years, 5 months ago (2012-07-12 09:20:24 UTC) #8
Change committed as 146305

Powered by Google App Engine
This is Rietveld 408576698