gdata: Use member functions of CacheEntry where it can

chrome/browser/chromeos/extensions/file_browser_private_api.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/extensions/file_browser_private_api.h"
 
 #include <utility>
 
 #include "base/base64.h"
 #include "base/bind.h"
@@ skipping 1844 matching lines @@
   system_service->cache()->GetCacheEntryOnUIThread(
       file_proto->gdata_entry().resource_id(),
       file_proto->file_md5(),
       base::Bind(
           &GetGDataFilePropertiesFunction::CacheStateReceived,
           this, property_dict));
 }
 
 void GetGDataFilePropertiesFunction::CacheStateReceived(
     base::DictionaryValue* property_dict,
-    bool success,
+    bool /* success */,
     const gdata::GDataCache::CacheEntry& cache_entry) {
-  const int cache_state = (success ? cache_entry.cache_state :
-                           gdata::GDataCache::CACHE_STATE_NONE);
-  property_dict->SetBoolean(
-      "isPinned",
-      gdata::GDataCache::IsCachePinned(cache_state));
+  // In case of an error (i.e. success is false), cache_entry.cache_state is
+  // set to CACHE_STATE_NONE.
+  property_dict->SetBoolean("isPinned", cache_entry.IsPinned());
+  property_dict->SetBoolean("isPresent", cache_entry.IsPresent());
+  property_dict->SetBoolean("isDirty", cache_entry.IsDirty());
 
-  property_dict->SetBoolean(
-      "isPresent",
-      gdata::GDataCache::IsCachePresent(cache_state));
-
-  property_dict->SetBoolean(
-      "isDirty",
-      gdata::GDataCache::IsCacheDirty(cache_state));
   CompleteGetFileProperties();
 }
 
 PinGDataFileFunction::PinGDataFileFunction() {
 }
 
 PinGDataFileFunction::~PinGDataFileFunction() {
 }
 
 bool PinGDataFileFunction::RunImpl() {
@@ skipping 517 matching lines @@
   gdata::GDataSystemService* system_service =
       gdata::GDataSystemServiceFactory::GetForProfile(profile_);
   if (!system_service || !system_service->file_system())
     return false;
 
   FilePath directory_path = GetVirtualPathFromURL(GURL(file_url_as_string));
   system_service->file_system()->RequestDirectoryRefresh(directory_path);
 
   return true;
 }