Moving test_api to api/test .

chrome/browser/extensions/api/test/test_api.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-#ifndef CHROME_BROWSER_EXTENSIONS_EXTENSION_TEST_API_H_
-#define CHROME_BROWSER_EXTENSIONS_EXTENSION_TEST_API_H_
+#ifndef CHROME_BROWSER_EXTENSIONS_API_TEST_TEST_API_H_
+#define CHROME_BROWSER_EXTENSIONS_API_TEST_TEST_API_H_
 #pragma once
 
 #include "base/values.h"
 #include "chrome/browser/extensions/extension_function.h"
 
 template <typename T> struct DefaultSingletonTraits;
 
+namespace extensions {
+
 // A function that is only available in tests.
 // Prior to running, checks that we are in an extension process.
 class TestExtensionFunction : public SyncExtensionFunction {
  protected:
   virtual ~TestExtensionFunction();
 
   // ExtensionFunction:
   virtual void Run() OVERRIDE;
 };
 
 class ExtensionTestPassFunction : public TestExtensionFunction {

[Yoyo Zhou, 2012/07/10 19:00:11]

Now that these are in the namespace, you don't need the Extension part of the
function names anymore. In fact, I would probably rename this one to
TestNotifyPassFunction to actually match the name in js. Same with the other
functions below.

[vabr (Chromium), 2012/07/11 10:01:25]

Done.

  public:
   DECLARE_EXTENSION_FUNCTION_NAME("test.notifyPass")
 
  protected:
   virtual ~ExtensionTestPassFunction();
 
   // ExtensionFunction:
   virtual bool RunImpl() OVERRIDE;
 };
 
@@ skipping 12 matching lines @@
  public:
   DECLARE_EXTENSION_FUNCTION_NAME("test.log")
 
  protected:
   virtual ~ExtensionTestLogFunction();
 
   // ExtensionFunction:
   virtual bool RunImpl() OVERRIDE;
 };
 
 class ExtensionTestQuotaResetFunction : public TestExtensionFunction {

[Yoyo Zhou, 2012/07/10 19:00:11]

This one seems like it should be called TestResetQuotaFunction.

[vabr (Chromium), 2012/07/11 10:01:25]

Done.

  public:
   DECLARE_EXTENSION_FUNCTION_NAME("test.resetQuota")
 
  protected:
   virtual ~ExtensionTestQuotaResetFunction();
 
   // ExtensionFunction:
   virtual bool RunImpl() OVERRIDE;
 };
 
@@ skipping 56 matching lines @@
 
     DISALLOW_COPY_AND_ASSIGN(TestConfigState);
   };
 
   virtual ~ExtensionTestGetConfigFunction();
 
   // ExtensionFunction:
   virtual bool RunImpl() OVERRIDE;
 };
 
-#endif  // CHROME_BROWSER_EXTENSIONS_EXTENSION_TEST_API_H_
+} // namespace extensions

[Yoyo Zhou, 2012/07/10 19:00:11]

nit: two spaces before the //

[vabr (Chromium), 2012/07/11 10:01:25]

Done.

+
+#endif  // CHROME_BROWSER_EXTENSIONS_API_TEST_TEST_API_H_