net/http/http_stream_parser_unittest.cc - Issue 10690104: DeterministicSocketDataProvider should not be RefCounted

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/http/http_stream_parser_unittest.cc

Issue 10690104: DeterministicSocketDataProvider should not be RefCounted (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: One more leak fix Created 8 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/http/http_stream_parser_unittest.cc

diff --git a/net/http/http_stream_parser_unittest.cc b/net/http/http_stream_parser_unittest.cc

index 843c9a673f9c33fca9a0bd0140709e855b40cf54..5a5c0aaf4db74e7d019dd4b751b180658b2ebcbc 100644

--- a/net/http/http_stream_parser_unittest.cc

+++ b/net/http/http_stream_parser_unittest.cc

@@ -194,13 +194,13 @@ TEST(HttpStreamParser, AsyncChunkAndAsyncSocket) {

MockRead(SYNCHRONOUS, 8, 0), // EOF

};

- scoped_refptr<DeterministicSocketData> data(

+ scoped_ptr<DeterministicSocketData> data(

new DeterministicSocketData(reads, arraysize(reads),

writes, arraysize(writes)));

data->set_connect_data(MockConnect(SYNCHRONOUS, OK));

scoped_ptr<DeterministicMockTCPClientSocket> transport(

- new DeterministicMockTCPClientSocket(NULL, data));

+ new DeterministicMockTCPClientSocket(NULL, data.get()));

data->set_socket(transport->AsWeakPtr());

TestCompletionCallback callback;