Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3906)

Unified Diff: base/base.gyp

Issue 10689161: Adds MessageLoopUIApplication for use on iOS. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: DCHECK and gyp changes. Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | base/base.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/base.gyp
diff --git a/base/base.gyp b/base/base.gyp
index 22798dd8b2a1117f58419caa1ae74f83ece0ee57..5ab35a3986115e33b86e102b0e6fbeb09e669a94 100644
--- a/base/base.gyp
+++ b/base/base.gyp
@@ -557,17 +557,20 @@
'sources/': [
# Only test the iOS-meaningful portion of process_utils.
['exclude', '^process_util_unittest'],
- ['include', '^process_util_unittest_ios.cc$'],
+ ['include', '^process_util_unittest_ios\\.cc$'],
# Requires spawning processes.
- ['exclude', '^metrics/stats_table_unittest.cc'],
+ ['exclude', '^metrics/stats_table_unittest\\.cc'],
Mark Mentovai 2012/07/12 15:59:03 Now put dollar signs at the ends of the ones in he
rohitrao (ping after 24h) 2012/07/12 16:30:56 Done (on the ones that are full paths).
# TODO(ios): Remove these as base/ is unforked.
# For now, exclude everything that doesn't build as-is, just to
# get a minimal target building.
- ['exclude', '^memory/aligned_memory_unittest.cc'],
- ['exclude', '^message_'],
- ['exclude', '^shared_memory_unittest.cc'],
- ['exclude', '^sys_info_unittest.cc'],
+ ['exclude', '^memory/aligned_memory_unittest\\.cc'],
+ ['exclude', '^shared_memory_unittest\\.cc'],
+ ['exclude', '^sys_info_unittest\\.cc'],
['exclude', '^system_monitor'],
+ # Unittests that don't pass.
+ ['exclude', '^message_loop_unittest\\.cc$'],
+ ['exclude', '^synchronization/waitable_event_watcher_unittest\\.cc$'],
+ ['exclude', '^timer_unittest\\.cc$'],
],
}],
['use_glib==1', {
@@ -636,8 +639,8 @@
'sources/': [
# Pull in specific Mac files for iOS (which have been filtered out
# by file name rules).
- ['include', 'mac/objc_property_releaser_unittest.mm'],
- ['include', 'sys_string_conversions_mac_unittest.mm'],
+ ['include', 'mac/objc_property_releaser_unittest\\.mm'],
Mark Mentovai 2012/07/12 15:59:03 Dollar signs on these two also. And these ones are
rohitrao (ping after 24h) 2012/07/12 16:30:56 Done.
+ ['include', 'sys_string_conversions_mac_unittest\\.mm'],
],
}],
], # target_conditions
« no previous file with comments | « no previous file | base/base.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698