Extensions Docs Server: Samples zip files

chrome/common/extensions/docs/server2/subversion_fetcher.py

 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
+import xml.dom.minidom as xml
+
 SUBVERSION_URL = 'http://src.chromium.org/chrome'
 TRUNK_URL = SUBVERSION_URL + '/trunk'
 BRANCH_URL = SUBVERSION_URL + '/branches'
 
 class SubversionFetcher(object):
   """Class to fetch resources from src.chromium.org.
   """
   def __init__(self, branch, base_path, url_fetcher):
     self._base_path = self._GetURLFromBranch(branch) + '/' + base_path
     self._url_fetcher = url_fetcher
 
   def _GetURLFromBranch(self, branch):
     if branch == 'trunk':
       return TRUNK_URL + '/src'
     return BRANCH_URL + '/' + branch + '/src'
 
+  def _ListDir(self, directory):
+    dom = xml.parseString(directory)
+    files = map(lambda x: x.childNodes[0].data, dom.getElementsByTagName('a'))

[not at google - send to devlin, 2012/07/12 07:06:29]

I think the "pythonic" way of doing map() is usually with list comprehensions

[cduvall, 2012/07/12 18:09:02]

Done.

+    if '..' in files:
+      files.remove('..')
+    return files
+
+  def _RecursiveList(self, files, base):
+    all_files = []
+    for filename in files:
+      if filename.endswith('/'):
+        dir_name = base + '/' + filename.split('/')[-2]
+        all_files.extend(self.ListDirectory(dir_name).content)

[not at google - send to devlin, 2012/07/12 07:06:29]

need to pass recursive=True here?

Or call _RecursiveList directly?

[cduvall, 2012/07/12 18:09:02]

Done.

+      else:
+        all_files.append(base + '/' + filename)
+    return all_files
+
+  def ListDirectory(self, path, recursive=False):
+    result = self._url_fetcher.fetch(self._base_path + '/' + path)

[not at google - send to devlin, 2012/07/12 07:06:29]

I don't see how this works, doesn't this return HTML, so if recursive is False
then it'll return some HTML rather than the list of files?

I would have expected this to be structured like

return _RecursiveList(path) if recursive else _ListDir(path)

[cduvall, 2012/07/12 18:09:02]

Done.

+    if recursive:
+      result.content = self._RecursiveList(self._ListDir(result.content), path)
+    return result
+
   def FetchResource(self, path):
     return self._url_fetcher.fetch(self._base_path + '/' + path)
+