Issue 10689106: Renaming Observer to OrientationObserver in DeviceOrientation

Issue 10689106: Renaming Observer to OrientationObserver in DeviceOrientation (Closed)

Created:
8 years, 5 months ago by aousterh

Modified:
8 years, 4 months ago

Reviewers:
bulach, Steve Block

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam

Base URL:
http://git.chromium.org/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Renaming Observer to OrientationObserver in DeviceOrientation Renames Observer to OrientationObserver and UpdateChecker to OrientationUpdateChecker in the corresponding tests. This will make it easier to add MotionObserver for DeviceMotion in a later patch (see http://codereview.chromium.org/10698046/). BUG=none TEST=browser_tests:DeviceOrientationBrowserTest.BasicTest, content_unittests --gtest_filter=DeviceOrientation*

Patch Set 1 #

Total comments: 4

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+115 lines, -108 lines)			Patch
M	build/android/gtest_filter/content_unittests_disabled	View	1 chunk	+1 line, -1 line	0 comments	Download
M	content/browser/device_orientation/device_orientation_browsertest.cc	View	2 chunks	+10 lines, -10 lines	0 comments	Download
M	content/browser/device_orientation/orientation_message_filter.h	View	1 chunk	+3 lines, -3 lines	1 comment	Download
M	content/browser/device_orientation/orientation_message_filter.cc	View	3 chunks	+24 lines, -24 lines	1 comment	Download
M	content/browser/device_orientation/provider.h	View	2 chunks	+9 lines, -8 lines	0 comments	Download
M	content/browser/device_orientation/provider_impl.h	View	2 chunks	+4 lines, -3 lines	1 comment	Download
M	content/browser/device_orientation/provider_impl.cc	View	2 chunks	+10 lines, -9 lines	0 comments	Download
M	content/browser/device_orientation/provider_unittest.cc	View	9 chunks	+54 lines, -50 lines	1 comment	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

bulach

lgtm, just a few nits below and one question: as discussed in http://codereview.chromium.org/10698046/, it seems ...

8 years, 5 months ago (2012-07-04 15:34:19 UTC) #2

Steve Block

lgtm https://chromiumcodereview.appspot.com/10689106/diff/1/content/browser/device_orientation/provider_unittest.cc File content/browser/device_orientation/provider_unittest.cc (right): https://chromiumcodereview.appspot.com/10689106/diff/1/content/browser/device_orientation/provider_unittest.cc#newcode346 content/browser/device_orientation/provider_unittest.cc:346: // This stops the Provider. Comment should be ...

8 years, 5 months ago (2012-07-04 15:34:38 UTC) #3

aousterh

8 years, 4 months ago (2012-08-03 17:15:04 UTC) #4

On 2012/07/04 15:34:38, Steve Block wrote:
> lgtm
> 
>
https://chromiumcodereview.appspot.com/10689106/diff/1/content/browser/device...
> File content/browser/device_orientation/provider_unittest.cc (right):
> 
>
https://chromiumcodereview.appspot.com/10689106/diff/1/content/browser/device...
> content/browser/device_orientation/provider_unittest.cc:346: // This stops the
> Provider.
> Comment should be above code.

As suggested by bulach, I refactored this instead, so that addition types of
device_data can be easily added in the future
(https://chromiumcodereview.appspot.com/10755002/). This patch is no longer
necessary.

Expand Messages | Collapse Messages