Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4335)

Unified Diff: chrome/browser/extensions/extension_service.h

Issue 10689097: Enforce the 'requirements' field in manifests. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: All New! (Removed sync tracing code) Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_service.h
diff --git a/chrome/browser/extensions/extension_service.h b/chrome/browser/extensions/extension_service.h
index f70bacb054d7ca1bb1269335e82dc0d0db109f7c..e47d3104516080435cca8c1008ac493a75738394 100644
--- a/chrome/browser/extensions/extension_service.h
+++ b/chrome/browser/extensions/extension_service.h
@@ -86,6 +86,7 @@ class ExtensionCookiesEventRouter;
class ExtensionSyncData;
class ExtensionSystem;
class ExtensionUpdater;
+class RequirementsProvider;
class SettingsFrontend;
class WebNavigationEventRouter;
}
@@ -350,6 +351,13 @@ class ExtensionService
virtual void DisableExtension(const std::string& extension_id,
extensions::Extension::DisableReason disable_reason);
+ // Called to report an extension that declares requirements that are not meet
Aaron Boodman 2012/07/22 17:46:25 s/meet/met/
+ // by the system. An install warning will be added to the extension, and if
+ // |disable_extension| is true, the extension will be disabled.
+ void UnsupportedRequirements(const std::string& extension_id,
+ const string16& error,
+ bool disable_extension);
+
// Updates the |extension|'s granted permissions lists to include all
// permissions in the |extension|'s manifest and re-enables the
// extension.
@@ -854,6 +862,9 @@ class ExtensionService
scoped_ptr<ExtensionErrorUI> extension_error_ui_;
+ // The provider that checks if an extension is supported.
+ scoped_ptr<extensions::RequirementsProvider> requirements_provider_;
+
FRIEND_TEST_ALL_PREFIXES(ExtensionServiceTest,
InstallAppsWithUnlimtedStorage);
FRIEND_TEST_ALL_PREFIXES(ExtensionServiceTest,
« no previous file with comments | « no previous file | chrome/browser/extensions/extension_service.cc » ('j') | chrome/browser/extensions/extension_service.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698