Enforce the 'requirements' field in manifests.

chrome/browser/extensions/unpacked_installer.h

Index: chrome/browser/extensions/unpacked_installer.h
diff --git a/chrome/browser/extensions/unpacked_installer.h b/chrome/browser/extensions/unpacked_installer.h
index 2cc3ec420545a708b23da80af55707d98b108377..300543745df329b282e747965f115a56e0a4d789 100644
--- a/chrome/browser/extensions/unpacked_installer.h
+++ b/chrome/browser/extensions/unpacked_installer.h
@@ -6,9 +6,11 @@
 #define CHROME_BROWSER_EXTENSIONS_UNPACKED_INSTALLER_H_
 
 #include <string>
+#include <vector>
 
 #include "base/file_path.h"
 #include "base/memory/ref_counted.h"
+#include "base/memory/scoped_ptr.h"
 #include "base/memory/weak_ptr.h"
 
 class ExtensionService;
@@ -16,6 +18,7 @@ class ExtensionService;
 namespace extensions {
 
 class Extension;
+class RequirementsChecker;
 
 // Installs and loads an unpacked extension.
 // TODO(erikkay): It might be useful to be able to load a packed extension
@@ -47,6 +50,12 @@ class UnpackedInstaller
   explicit UnpackedInstaller(ExtensionService* extension_service);
   virtual ~UnpackedInstaller();
 
+  // Must be called from the UI thread.
+  void RunRequirementsChecker();

[Yoyo Zhou, 2012/08/02 22:23:30]

Same comment here (CheckRequirements). Seeing this common definition makes me
think it should be defined as a RequirementsChecker::Delegate interface. Aaron,
thoughts?

[eaugusti, 2012/08/03 01:06:26]

Done.

[Aaron Boodman, 2012/08/06 20:36:07]

I'm kinda in to using WeakPtr callbacks where Chrome would traditionally use
delegates. The advantage is that the framework automatically handles the
lifetime issues for you. If we used a delegate here we'd have to manually ensure
it did not get called back after it had been deleted.

+
+  // Callback from RequirementsChecker.
+  void RequirementsChecked(std::vector<std::string> errors);
+
   // Verifies if loading unpacked extensions is allowed.
   bool IsLoadingUnpackedAllowed() const;
 
@@ -65,7 +74,7 @@ class UnpackedInstaller
   void ReportExtensionLoadError(const std::string& error);
 
   // Called when an unpacked extension has been loaded and installed.
-  void OnLoaded(const scoped_refptr<const Extension>& extension);
+  void OnLoaded();
 
   base::WeakPtr<ExtensionService> service_weak_;
 
@@ -77,6 +86,10 @@ class UnpackedInstaller
   // loading.
   bool prompt_for_plugins_;
 
+  scoped_ptr<RequirementsChecker> requirements_checker_;
+
+  scoped_refptr<const Extension> extension_;
+
   DISALLOW_COPY_AND_ASSIGN(UnpackedInstaller);
 };