Enforce the 'requirements' field in manifests.

chrome/browser/ui/webui/extensions/extension_settings_handler.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/webui/extensions/extension_settings_handler.h"
 
 #include "base/auto_reset.h"
 #include "base/base64.h"
 #include "base/bind.h"
 #include "base/bind_helpers.h"
 #include "base/command_line.h"
 #include "base/file_util.h"
 #include "base/string_number_conversions.h"
 #include "base/utf_string_conversions.h"
 #include "base/values.h"
 #include "base/version.h"
 #include "chrome/browser/browser_process.h"
 #include "chrome/browser/debugger/devtools_window.h"
 #include "chrome/browser/extensions/crx_installer.h"
 #include "chrome/browser/extensions/extension_disabled_ui.h"
+#include "chrome/browser/extensions/extension_error_reporter.h"
 #include "chrome/browser/extensions/extension_host.h"
 #include "chrome/browser/extensions/extension_service.h"
 #include "chrome/browser/extensions/extension_system.h"
 #include "chrome/browser/extensions/extension_warning_set.h"
 #include "chrome/browser/extensions/lazy_background_task_queue.h"
 #include "chrome/browser/extensions/unpacked_installer.h"
 #include "chrome/browser/extensions/updater/extension_updater.h"
 #include "chrome/browser/google/google_util.h"
 #include "chrome/browser/managed_mode.h"
 #include "chrome/browser/prefs/pref_service.h"
@@ skipping 154 matching lines @@
            ++iter) {
         string16 warning_string(
             ExtensionWarningSet::GetLocalizedWarning(*iter));
         warnings_list->Append(Value::CreateStringValue(warning_string));
       }
       extension_data->Set("warnings", warnings_list);
     }
   }
 
   // Add install warnings (these are not the same as warnings!).
-  if (extension->location() == Extension::LOAD) {
+  if (extension->location() == Extension::LOAD ||
+      extension_service_->extension_prefs()->HasUnsupportedRequirements(

[Aaron Boodman, 2012/08/01 03:58:54]

Yeah, I don't think we want to do this. Did I say this in the doc or something?

[eaugusti, 2012/08/03 01:06:26]

This wasn't in the doc, but I think it is the best way to persistently show
these warnings.

+          extension->id())) {
     const Extension::InstallWarningVector& install_warnings =
         extension->install_warnings();
     if (!install_warnings.empty()) {
       scoped_ptr<ListValue> list(new ListValue());
       for (Extension::InstallWarningVector::const_iterator it =
                install_warnings.begin(); it != install_warnings.end(); ++it) {
         DictionaryValue* item = new DictionaryValue();
         item->SetBoolean("isHTML",
                          it->format == Extension::InstallWarning::FORMAT_HTML);
         item->SetString("message", it->message);
@@ skipping 409 matching lines @@
     return;
   }
 
   if (enable_str == "true") {
     extensions::ExtensionPrefs* prefs = extension_service_->extension_prefs();
     if (prefs->DidExtensionEscalatePermissions(extension_id)) {
       Browser* browser = browser::FindBrowserWithWebContents(
           web_ui()->GetWebContents());
       extensions::ShowExtensionDisabledDialog(
           extension_service_, browser, extension);
+    } else if (prefs->HasUnsupportedRequirements(extension_id)) {

[Aaron Boodman, 2012/08/01 03:58:54]

Seems like you could check the disable reason instead. This is also stored in
prefs.

[eaugusti, 2012/08/03 01:06:26]

Done.

+      // TODO(eriq): i18n
+      ExtensionErrorReporter::GetInstance()->ReportError(
+          ASCIIToUTF16("Cannot enable, not all requirements are met."),
+          true /* be noisy */);
     } else {
       extension_service_->EnableExtension(extension_id);
     }
   } else {
     extension_service_->DisableExtension(
         extension_id, Extension::DISABLE_USER_ACTION);
   }
 }
 
 void ExtensionSettingsHandler::HandleEnableIncognitoMessage(
@@ skipping 241 matching lines @@
   return extension_uninstall_dialog_.get();
 #else
   return NULL;
 #endif  // !defined(OS_ANDROID)
 }
 
 void ExtensionSettingsHandler::InspectExtensionHost(ExtensionHost* host) {
   if (host)
     DevToolsWindow::OpenDevToolsWindow(host->render_view_host());
 }