Enforce the 'requirements' field in manifests.

chrome/browser/extensions/unpacked_installer.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_EXTENSIONS_UNPACKED_INSTALLER_H_
 #define CHROME_BROWSER_EXTENSIONS_UNPACKED_INSTALLER_H_
 
 #include <string>
+#include <vector>
 
 #include "base/file_path.h"
 #include "base/memory/ref_counted.h"
+#include "base/memory/scoped_ptr.h"
 #include "base/memory/weak_ptr.h"
 
 class ExtensionService;
 
 namespace extensions {
 
 class Extension;
+class RequirementsChecker;
 
 // Installs and loads an unpacked extension.
 // TODO(erikkay): It might be useful to be able to load a packed extension
 // (presumably into memory) without installing it.
 class UnpackedInstaller
     : public base::RefCountedThreadSafe<UnpackedInstaller> {
  public:
   static scoped_refptr<UnpackedInstaller> Create(
       ExtensionService* extension_service);
 
@@ skipping 11 matching lines @@
   // Allows prompting for plugins to be disabled; intended for testing only.
   bool prompt_for_plugins() { return prompt_for_plugins_; }
   void set_prompt_for_plugins(bool val) { prompt_for_plugins_ = val; }
 
  private:
   friend class base::RefCountedThreadSafe<UnpackedInstaller>;
 
   explicit UnpackedInstaller(ExtensionService* extension_service);
   virtual ~UnpackedInstaller();
 
+  // Must be called from the UI thread.
+  void RunRequirementsChecker();

[Yoyo Zhou, 2012/08/02 22:23:30]

Same comment here (CheckRequirements). Seeing this common definition makes me
think it should be defined as a RequirementsChecker::Delegate interface. Aaron,
thoughts?

[eaugusti, 2012/08/03 01:06:26]

Done.

[Aaron Boodman, 2012/08/06 20:36:07]

I'm kinda in to using WeakPtr callbacks where Chrome would traditionally use
delegates. The advantage is that the framework automatically handles the
lifetime issues for you. If we used a delegate here we'd have to manually ensure
it did not get called back after it had been deleted.

+
+  // Callback from RequirementsChecker.
+  void RequirementsChecked(std::vector<std::string> errors);
+
   // Verifies if loading unpacked extensions is allowed.
   bool IsLoadingUnpackedAllowed() const;
 
   // We change the input extension path to an absolute path, on the file thread.
   // Then we need to check the file access preference, which needs
   // to happen back on the UI thread, so it posts CheckExtensionFileAccess on
   // the UI thread. In turn, once that gets the pref, it goes back to the
   // file thread with LoadWithFileAccess.
   // TODO(yoz): It would be nice to remove this ping-pong, but we need to know
   // what file access flags to pass to extension_file_util::LoadExtension.
   void GetAbsolutePath();
   void CheckExtensionFileAccess();
   void LoadWithFileAccess(bool allow_file_access);
 
   // Notify the frontend that there was an error loading an extension.
   void ReportExtensionLoadError(const std::string& error);
 
   // Called when an unpacked extension has been loaded and installed.
-  void OnLoaded(const scoped_refptr<const Extension>& extension);
+  void OnLoaded();
 
   base::WeakPtr<ExtensionService> service_weak_;
 
   // The pathname of the directory to load from, which is an absolute path
   // after GetAbsolutePath has been called.
   FilePath extension_path_;
 
   // If true and the extension contains plugins, we prompt the user before
   // loading.
   bool prompt_for_plugins_;
 
+  scoped_ptr<RequirementsChecker> requirements_checker_;
+
+  scoped_refptr<const Extension> extension_;
+
   DISALLOW_COPY_AND_ASSIGN(UnpackedInstaller);
 };
 
 }  // namespace extensions
 
 #endif  // CHROME_BROWSER_EXTENSIONS_UNPACKED_INSTALLER_H_