Enforce the 'requirements' field in manifests.

chrome/browser/extensions/extension_service.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/extension_service.h"
 
 #include <algorithm>
 #include <set>
 
 #include "base/basictypes.h"
@@ skipping 2075 matching lines @@
     if (!extension->is_theme() && extension->location() != Extension::COMPONENT)
       extension_ids.insert(extension->id());
   }
 
   child_process_logging::SetActiveExtensions(extension_ids);
 }
 
 void ExtensionService::OnExtensionInstalled(
     const Extension* extension,
     bool from_webstore,
-    const StringOrdinal& page_ordinal) {
+    const StringOrdinal& page_ordinal,
+    const std::vector<std::string>& requirement_errors) {
   CHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
 
   // Ensure extension is deleted unless we transfer ownership.
   scoped_refptr<const Extension> scoped_extension(extension);
   const std::string& id = extension->id();
   // Extensions installed by policy can't be disabled. So even if a previous
   // installation disabled the extension, make sure it is now enabled.
   bool initial_enable =
       !extension_prefs_->IsExtensionDisabled(id) ||
       system_->management_policy()->MustRemainEnabled(extension, NULL);
@@ skipping 26 matching lines @@
     pending_extension_manager()->Remove(id);
   } else {
     // We explicitly want to re-enable an uninstalled external
     // extension; if we're here, that means the user is manually
     // installing the extension.
     if (IsExternalExtensionUninstalled(id)) {
       initial_enable = true;
     }
   }
 
+  // Unsupported requirements overrides the management policy.
+  if (!requirement_errors.empty()) {
+    initial_enable = false;

[Aaron Boodman, 2012/08/01 03:58:54]

Oh cool. Since we already had code that was initially disabling extensions on
install, I guess we can assume that it already works, and the comment in the doc
about carefully making sure this doesn't confuse clients doesn't apply.

[eaugusti, 2012/08/03 01:06:26]

Done.

+  // If the extension was disabled because of unsupported requirements but
+  // now supports all requirements after an update, enable it.
+  } else if (extension_prefs_->HasUnsupportedRequirements(id)) {

[Aaron Boodman, 2012/08/01 03:58:54]

Can you check whether state == DISABLE_UNSUPPORTED_REQUIREMENTS instead? If so,
can you remove the unsupported requirements pref?

[eaugusti, 2012/08/03 01:06:26]

If we remove the unsupported requirements in the perfs, then we will be unable
to display the warnings on updated/sync'd extensions after a restart.

+    initial_enable = true;
+  }
+
   // Do not record the install histograms for upgrades.
   if (!GetExtensionByIdInternal(extension->id(), true, true, false)) {
     UMA_HISTOGRAM_ENUMERATION("Extensions.InstallType",
                               extension->GetType(), 100);
     RecordPermissionMessagesHistogram(
         extension, "Extensions.Permissions_Install");
   }
 
   // Certain extension locations are specific enough that we can
   // auto-acknowledge any extension that came from one of them.
   if (extension->location() == Extension::EXTERNAL_POLICY_DOWNLOAD) {
     AcknowledgeExternalExtension(extension->id());
   }
 
   extension_prefs_->OnExtensionInstalled(
       extension,
       initial_enable ? Extension::ENABLED : Extension::DISABLED,
       from_webstore,
       page_ordinal);
 
+  if (!requirement_errors.empty()) {
+    extension_prefs_->SetDisableReason(
+        id, Extension::DISABLE_UNSUPPORTED_REQUIREMENT);
+    extension_prefs_->SetUnsupportedRequirements(id, requirement_errors);
+  }
+
   // Unpacked extensions default to allowing file access, but if that has been
   // overridden, don't reset the value.
   if (Extension::ShouldAlwaysAllowFileAccess(extension->location()) &&
       !extension_prefs_->HasAllowFileAccessSetting(id)) {
     extension_prefs_->SetAllowFileAccess(id, true);
   }
 
   content::NotificationService::current()->Notify(
       chrome::NOTIFICATION_EXTENSION_INSTALLED,
       content::Source<Profile>(profile_),
@@ skipping 367 matching lines @@
 
 ExtensionService::NaClModuleInfoList::iterator
     ExtensionService::FindNaClModule(const GURL& url) {
   for (NaClModuleInfoList::iterator iter = nacl_module_list_.begin();
        iter != nacl_module_list_.end(); ++iter) {
     if (iter->url == url)
       return iter;
   }
   return nacl_module_list_.end();
 }