Enforce the 'requirements' field in manifests.

chrome/browser/extensions/extension_prefs.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/extension_prefs.h"
 
 #include "base/string_number_conversions.h"
 #include "base/string_util.h"
 #include "base/utf_string_conversions.h"
 #include "chrome/browser/extensions/admin_policy.h"
@@ skipping 45 matching lines @@
 const char kPrefAppNotificationDisbaled[] = "app_notif_disabled";
 
 // Indicates whether the user has acknowledged various types of extensions.
 const char kPrefExternalAcknowledged[] = "ack_external";
 const char kPrefBlacklistAcknowledged[] = "ack_blacklist";
 const char kPrefOrphanAcknowledged[] = "ack_orphan";
 
 // Indicates whether to show an install warning when the user enables.
 const char kExtensionDidEscalatePermissions[] = "install_warning_on_enable";
 
+// Any errors that arose from unmet unmet requirements.

[Aaron Boodman, 2012/08/01 03:58:54]

duplicate 'unmet'

[eaugusti, 2012/08/03 01:06:26]

Done.

+const char kUnsupportedRequirements[] = "unsupported_requirements";
+
 // Indicates whether the extension was updated while it was disabled.
 const char kPrefDisableReason[] = "disable_reason";
 
 // A preference that tracks browser action toolbar configuration. This is a list
 // object stored in the Preferences file. The extensions are stored by ID.
 const char kExtensionToolbar[] = "extensions.toolbar";
 
 // The key for a serialized Time value indicating the start of the day (from the
 // server's perspective) an extension last included a "ping" parameter during
 // its update check.
@@ skipping 541 matching lines @@
   UpdateExtensionPref(extension_id, kPrefAppNotificationClientId,
                       Value::CreateStringValue(oauth_client_id));
 }
 
 bool ExtensionPrefs::IsAppNotificationDisabled(
     const std::string& extension_id) const {
   return ReadExtensionPrefBoolean(extension_id, kPrefAppNotificationDisbaled);
 }
 
 void ExtensionPrefs::SetAppNotificationDisabled(
-   const std::string& extension_id, bool value) {
+    const std::string& extension_id, bool value) {
   DCHECK(Extension::IdIsValid(extension_id));
   UpdateExtensionPref(extension_id, kPrefAppNotificationDisbaled,
                       Value::CreateBooleanValue(value));
 }
 
 std::string ExtensionPrefs::GetDebugPolicyProviderName() const {
 #ifdef NDEBUG
   NOTREACHED();
   return std::string();
 #else
   return "admin policy black/white/forcelist, via the ExtensionPrefs";
 #endif
 }
 
 bool ExtensionPrefs::UserMayLoad(const Extension* extension,
                                  string16* error) const {
-

[Aaron Boodman, 2012/08/01 03:58:54]

stray edit

[eaugusti, 2012/08/03 01:06:26]

Done.

   const base::ListValue* blacklist =
       prefs_->GetList(prefs::kExtensionInstallDenyList);
   const base::ListValue* whitelist =
       prefs_->GetList(prefs::kExtensionInstallAllowList);
   return admin_policy::UserMayLoad(blacklist, whitelist, extension,
                                                error);
 }
 
 bool ExtensionPrefs::UserMayModifySettings(const Extension* extension,
                                            string16* error) const {
@@ skipping 15 matching lines @@
   return ReadExtensionPrefBoolean(extension_id,
                                   kExtensionDidEscalatePermissions);
 }
 
 void ExtensionPrefs::SetDidExtensionEscalatePermissions(
     const Extension* extension, bool did_escalate) {
   UpdateExtensionPref(extension->id(), kExtensionDidEscalatePermissions,
                       Value::CreateBooleanValue(did_escalate));
 }
 
+bool ExtensionPrefs::HasUnsupportedRequirements(
+    const std::string& extension_id) {
+  const ListValue* requirement_errors = NULL;
+  return ReadExtensionPrefList(extension_id,
+                               kUnsupportedRequirements,
+                               &requirement_errors);
+}
+
+void ExtensionPrefs::ClearUnsupportedRequirements(
+    const std::string& extension_id) {
+  UpdateExtensionPref(extension_id, kUnsupportedRequirements, NULL);
+}
+
+void ExtensionPrefs::SetUnsupportedRequirements(
+    const std::string& extension_id,
+    std::vector<std::string> requirement_errors) {
+  ListValue* errors_list = new ListValue();

[Aaron Boodman, 2012/08/01 03:58:54]

Are there other functions in this class doing the same pattern of
std::vector<std::string> -> ListValue? If so, please pull out a
UpdateExtensionPrefList() or someting.

[eaugusti, 2012/08/03 01:06:26]

No one uses this exact functionality, but I can still pull it out for later.

+  std::vector<std::string>::iterator it;
+  for (it = requirement_errors.begin(); it != requirement_errors.end(); ++it)
+    errors_list->Append(Value::CreateStringValue(*it));
+  UpdateExtensionPref(extension_id, kUnsupportedRequirements, errors_list);
+}
+
+std::vector<std::string> ExtensionPrefs::GetUnsupportedRequirements(
+    const std::string& extension_id) {
+  std::vector<std::string> requirement_errors;
+  const ListValue* errors = NULL;
+  if (ReadExtensionPrefList(extension_id, kUnsupportedRequirements,

[Aaron Boodman, 2012/08/01 03:58:54]

Same comment about potentially pulling out duplicated code.

[eaugusti, 2012/08/03 01:06:26]

Done.

+                            &errors)) {
+    for (size_t i = 0; i < errors->GetSize(); ++i) {
+      std::string requirement_error;
+      if (errors->GetString(i, &requirement_error))
+        requirement_errors.push_back(requirement_error);
+    }
+  }
+  return requirement_errors;
+}
+
 Extension::DisableReason ExtensionPrefs::GetDisableReason(
     const std::string& extension_id) {
   int value = -1;
   if (ReadExtensionPrefInteger(extension_id, kPrefDisableReason, &value) &&
       value >= 0 && value < Extension::DISABLE_LAST) {
     return static_cast<Extension::DisableReason>(value);
   }
   return Extension::DISABLE_UNKNOWN;
 }
 
@@ skipping 136 matching lines @@
 void ExtensionPrefs::SetActiveBit(const std::string& extension_id,
                                   bool active) {
   UpdateExtensionPref(extension_id, kActiveBit,
                       Value::CreateBooleanValue(active));
 }
 
 void ExtensionPrefs::MigratePermissions(const ExtensionIdSet& extension_ids) {
   PermissionsInfo* info = PermissionsInfo::GetInstance();
   for (ExtensionIdSet::const_iterator ext_id =
        extension_ids.begin(); ext_id != extension_ids.end(); ++ext_id) {
-
     // An extension's granted permissions need to be migrated if the

[Aaron Boodman, 2012/08/01 03:58:54]

stray edit

[eaugusti, 2012/08/03 01:06:26]

Done.

     // full_access bit is present. This bit was always present in the previous
     // scheme and is never present now.
     bool full_access;
     const DictionaryValue* ext = GetExtensionPref(*ext_id);
     if (!ext || !ext->GetBoolean(kPrefOldGrantedFullAccess, &full_access))
       continue;
 
     // Remove the full access bit (empty list will get trimmed).
     UpdateExtensionPref(
         *ext_id, kPrefOldGrantedFullAccess, new ListValue());
@@ skipping 1086 matching lines @@
                            0,  // default value
                            PrefService::UNSYNCABLE_PREF);
   prefs->RegisterInt64Pref(prefs::kNextExtensionsUpdateCheck,
                            0,  // default value
                            PrefService::UNSYNCABLE_PREF);
   prefs->RegisterListPref(prefs::kExtensionAllowedInstallSites,
                           PrefService::UNSYNCABLE_PREF);
 }
 
 }  // namespace extensions