chrome/browser/ui/panels/detached_panel_browsertest.cc - Issue 10689082: Fix flaky linux panel tests related to active state checks

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/panels/detached_panel_browsertest.cc

Issue 10689082: Fix flaky linux panel tests related to active state checks (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Cleaned up log msgs. Add fix to new tests. Created 8 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/panels/detached_panel_browsertest.cc

diff --git a/chrome/browser/ui/panels/detached_panel_browsertest.cc b/chrome/browser/ui/panels/detached_panel_browsertest.cc

index 5b836cea83be65968e722fc9689b4cfe4b5efd45..ce73eac01b63459e13d1c775f11d111942bf3f01 100644

--- a/chrome/browser/ui/panels/detached_panel_browsertest.cc

+++ b/chrome/browser/ui/panels/detached_panel_browsertest.cc

@@ -135,7 +135,7 @@ IN_PROC_BROWSER_TEST_F(DetachedPanelBrowserTest, ClickTitlebar) {

// Create a second panel to cause the first to become inactive.

CreateDetachedPanel("2", gfx::Rect(100, 200, 230, 345));

- EXPECT_FALSE(panel->IsActive());

+ WaitForPanelActiveState(panel, SHOW_AS_INACTIVE);

// Clicking on an inactive detached panel's titlebar activates it.

test_panel->PressLeftMouseButtonTitlebar(panel->GetBounds().origin());