Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4236)

Unified Diff: chrome/browser/ui/panels/base_panel_browser_test.h

Issue 10689082: Fix flaky linux panel tests related to active state checks (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Cleaned up log msgs. Add fix to new tests. Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/panels/base_panel_browser_test.h
diff --git a/chrome/browser/ui/panels/base_panel_browser_test.h b/chrome/browser/ui/panels/base_panel_browser_test.h
index e9fbebe1fd8b9e7f6e64a2b46f298d8b36a9fa5c..4ada135809ee96e5760ea5c67fcb94318ecf0a36 100644
--- a/chrome/browser/ui/panels/base_panel_browser_test.h
+++ b/chrome/browser/ui/panels/base_panel_browser_test.h
@@ -41,7 +41,7 @@ class BasePanelBrowserTest : public InProcessBrowserTest {
// Linux bots use icewm which activate windows in ways that break
// certain panel tests. Skip those tests when running on the bots.
// We do not disable the tests to make it easy for developers to run
- // them locally.
+ // them locally. [Icewm always activates a window when shown.]
bool SkipTestIfIceWM();
// Gnome running compiz refuses to activate a window that was initially

Powered by Google App Engine
This is Rietveld 408576698