Fix flaky linux panel tests related to active state checks

Fix flaky linux panel tests related to active state checks.

Set up signal that waits for expected active state transitioning. Make sure we consume previous notifications before waiting on new ones.

BUG=135377
TEST=re-enabled

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=145804

[dcheng, 2012-07-03 23:04:25]

http://codereview.chromium.org/10689082/diff/14001/chrome/browser/ui/panels/o...
File chrome/browser/ui/panels/old_base_panel_browser_test.cc (right):

http://codereview.chromium.org/10689082/diff/14001/chrome/browser/ui/panels/o...
chrome/browser/ui/panels/old_base_panel_browser_test.cc:260:
EXPECT_TRUE(expect_active == is_active);
EXPECT_EQ

http://codereview.chromium.org/10689082/diff/14001/chrome/browser/ui/panels/o...
chrome/browser/ui/panels/old_base_panel_browser_test.cc:262: LOG(WARNING) <<
"Expected active: " << expect_active
Did you mean to print this out in two different formats?

http://codereview.chromium.org/10689082/diff/14001/chrome/browser/ui/panels/o...
File chrome/browser/ui/panels/old_panel_browsertest.cc (right):

http://codereview.chromium.org/10689082/diff/14001/chrome/browser/ui/panels/o...
chrome/browser/ui/panels/old_panel_browsertest.cc:968: // Create 2 panels so we
end up with an inactive panel that can
"Create 2 panels"... hmm!

http://codereview.chromium.org/10689082/diff/14001/chrome/browser/ui/panels/p...
File chrome/browser/ui/panels/panel_browsertest.cc (right):

http://codereview.chromium.org/10689082/diff/14001/chrome/browser/ui/panels/p...
chrome/browser/ui/panels/panel_browsertest.cc:975: // Create 2 panels so we end
up with an inactive panel that can
Hmm. "Create 2 panels"... =)

[jennb, 2012-07-03 23:08:55]

On Tue, Jul 3, 2012 at 4:04 PM, <dcheng@chromium.org> wrote:

>
> http://codereview.chromium.**org/10689082/diff/14001/**
>
chrome/browser/ui/panels/old_**base_panel_browser_test.cc<http://codereview.chromium.org/10689082/diff/14001/chrome/browser/ui/panels/old_base_panel_browser_test.cc>
> File chrome/browser/ui/panels/old_**base_panel_browser_test.cc (right):
>
> http://codereview.chromium.**org/10689082/diff/14001/**
>
chrome/browser/ui/panels/old_**base_panel_browser_test.cc#**newcode260<http://codereview.chromium.org/10689082/diff/14001/chrome/browser/ui/panels/old_base_panel_browser_test.cc#newcode260>
> chrome/browser/ui/panels/old_**base_panel_browser_test.cc:**260:
> EXPECT_TRUE(expect_active == is_active);
> EXPECT_EQ
>

Earlier attempts to change this didn't do what I expected, so I'm leaving
it as EXPECT_TRUE.


>
> http://codereview.chromium.**org/10689082/diff/14001/**
>
chrome/browser/ui/panels/old_**base_panel_browser_test.cc#**newcode262<http://codereview.chromium.org/10689082/diff/14001/chrome/browser/ui/panels/old_base_panel_browser_test.cc#newcode262>
> chrome/browser/ui/panels/old_**base_panel_browser_test.cc:**262:
> LOG(WARNING) << "Expected active: " << expect_active
> Did you mean to print this out in two different formats?
>

Intentional because I want to see the actual value of the bool in addition
to whether it's treated as true/false.


>
> http://codereview.chromium.**org/10689082/diff/14001/**
>
chrome/browser/ui/panels/old_**panel_browsertest.cc<http://codereview.chromium.org/10689082/diff/14001/chrome/browser/ui/panels/old_panel_browsertest.cc>
> File chrome/browser/ui/panels/old_**panel_browsertest.cc (right):
>
> http://codereview.chromium.**org/10689082/diff/14001/**
>
chrome/browser/ui/panels/old_**panel_browsertest.cc#**newcode968<http://codereview.chromium.org/10689082/diff/14001/chrome/browser/ui/panels/old_panel_browsertest.cc#newcode968>
> chrome/browser/ui/panels/old_**panel_browsertest.cc:968: // Create 2
> panels so we end up with an inactive panel that can
> "Create 2 panels"... hmm!
>
> http://codereview.chromium.**org/10689082/diff/14001/**
>
chrome/browser/ui/panels/**panel_browsertest.cc<http://codereview.chromium.org/10689082/diff/14001/chrome/browser/ui/panels/panel_browsertest.cc>
> File chrome/browser/ui/panels/**panel_browsertest.cc (right):
>
> http://codereview.chromium.**org/10689082/diff/14001/**
>
chrome/browser/ui/panels/**panel_browsertest.cc#**newcode975<http://codereview.chromium.org/10689082/diff/14001/chrome/browser/ui/panels/panel_browsertest.cc#newcode975>
> chrome/browser/ui/panels/**panel_browsertest.cc:975: // Create 2 panels so
> we end up with an inactive panel that can
> Hmm. "Create 2 panels"... =)
>

Will fix these last 2.


>
>
http://codereview.chromium.**org/10689082/<http://codereview.chromium.org/106...
>

[jennb, 2012-07-09 21:50:22]

Ready for another look.

[dcheng, 2012-07-09 22:29:32]

lgtm

[commit-bot: I haz the power, 2012-07-09 22:30:12]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jennb@chromium.org/10689082/34001

[commit-bot: I haz the power, 2012-07-09 23:36:01]

Commit queue rejected this change because the description was changed
between the time the change entered the commit queue and the time it
was ready to commit. You can safely check the commit box again.