Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1506)

Unified Diff: chrome/browser/extensions/api/tabs/tabs.cc

Issue 10689071: Deprecate --aura-panels (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/chromeos/login/login_utils.cc ('k') | chrome/browser/extensions/window_open_apitest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/api/tabs/tabs.cc
diff --git a/chrome/browser/extensions/api/tabs/tabs.cc b/chrome/browser/extensions/api/tabs/tabs.cc
index 3d80a52e7ef640dd813a48194a717a80f717f276..d3e8f44913209f387f3602acc0e07ed63f2bd46d 100644
--- a/chrome/browser/extensions/api/tabs/tabs.cc
+++ b/chrome/browser/extensions/api/tabs/tabs.cc
@@ -554,14 +554,9 @@ bool CreateWindowFunction::RunImpl() {
} else if (type_str == keys::kWindowTypeValuePanel) {
extension_id = GetExtension()->id();
bool use_panels = false;
-#if !defined(OS_ANDROID)
+#if !defined(OS_ANDROID) && !defined(USE_ASH)
use_panels = PanelManager::ShouldUsePanels(extension_id);
#endif
-#if defined(USE_ASH)
- if (CommandLine::ForCurrentProcess()->HasSwitch(
- ash::switches::kAuraPanelManager))
- use_panels = true;
-#endif
if (use_panels)
window_type = Browser::TYPE_PANEL;
else
@@ -576,18 +571,7 @@ bool CreateWindowFunction::RunImpl() {
if (window_type == Browser::TYPE_PANEL) {
std::string title =
web_app::GenerateApplicationNameFromExtensionId(extension_id);
-#if defined(USE_ASH)
- // Aura Panels create a new PanelViewAura.
- if (CommandLine::ForCurrentProcess()->HasSwitch(
- ash::switches::kAuraPanelManager)) {
- // Note: Panels ignore all but the first url provided.
- PanelViewAura* panel_view = new PanelViewAura(title);
- panel_view->Init(window_profile, urls[0], panel_bounds);
- result_.reset(panel_view->extension_window_controller()->
- CreateWindowValueWithTabs());
- return true;
- }
-#else
+#if !defined(USE_ASH)
if (CommandLine::ForCurrentProcess()->HasSwitch(
switches::kBrowserlessPanels)) {
// Note: Panels ignore all but the first url provided.
« no previous file with comments | « chrome/browser/chromeos/login/login_utils.cc ('k') | chrome/browser/extensions/window_open_apitest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698