Deprecate --aura-panels

Deprecate --aura-panels

Ash panels will be triggered only by the experimental appWindow.create apps v2 API, and no longer require a separate flag.
Support for Ash panels with apps v1 is deprecated.

BUG=none
TEST=unit/browser tests should pass, test panels should work in ash shell without flag.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=145401

[stevenjb, 2012-07-02 16:53:58]

http://codereview.chromium.org/10689071/diff/1/chrome/browser/ui/extensions/a...
File chrome/browser/ui/extensions/application_launch.cc (left):

http://codereview.chromium.org/10689071/diff/1/chrome/browser/ui/extensions/a...
chrome/browser/ui/extensions/application_launch.cc:108: case
extension_misc::LAUNCH_PANEL: {
not: I've spoken to the apps team, and they very much want to deprecate apps
launched as panels entirely, so I removed this for both Ash and
--browserless-panels.

[stevenjb, 2012-07-02 16:55:24]

+sky for ash/ review

[jennb, 2012-07-02 17:13:27]

chrome/browser/ui/panels/panel_app_browsertest.cc is obsoleted by this change
and should be deleted.

http://codereview.chromium.org/10689071/diff/1/chrome/browser/ui/extensions/a...
File chrome/browser/ui/extensions/application_launch.cc (left):

http://codereview.chromium.org/10689071/diff/1/chrome/browser/ui/extensions/a...
chrome/browser/ui/extensions/application_launch.cc:118: tab =
OpenApplicationPanel(profile, extension, override_url);
Can delete OpenApplicationPanel() method as well.

[stevenjb, 2012-07-03 15:25:59]

PTAL
Addressed comments + fixed or removed some additional deprecated tests / code.

[jennb, 2012-07-03 16:58:02]

LGTM for desktop panels changes.

http://codereview.chromium.org/10689071/diff/21/chrome/browser/ui/extensions/...
File chrome/browser/ui/extensions/application_launch.cc (left):

http://codereview.chromium.org/10689071/diff/21/chrome/browser/ui/extensions/...
chrome/browser/ui/extensions/application_launch.cc:140: WebContents*
OpenApplicationPanel(
Delete in .h as well.

[stevenjb, 2012-07-03 20:51:03]

Ben, would you mind taking a look at this since Scott is out? This is in
preparation for making Ash panels available only as part of the new Apps v2 API
(which is already behind a flag). Thanks!

[Ben Goodger (Google), 2012-07-03 21:47:01]

nice. lgtm.

[commit-bot: I haz the power, 2012-07-03 21:51:51]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/stevenjb@chromium.org/10689071/10007

[commit-bot: I haz the power, 2012-07-03 21:52:00]

Failed to apply patch for chrome/browser/ui/extensions/application_launch.cc:
While running patch -p1 --forward --force;
patching file chrome/browser/ui/extensions/application_launch.cc
Hunk #2 FAILED at 123.
1 out of 2 hunks FAILED -- saving rejects to file
chrome/browser/ui/extensions/application_launch.cc.rej

[commit-bot: I haz the power, 2012-07-03 22:13:24]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/stevenjb@chromium.org/10689071/11010

[commit-bot: I haz the power, 2012-07-03 23:56:22]

Change committed as 145401