SPDY - chunked upload - speech recognition doesn't work with SPDY/3

net/base/upload_data_stream.h

Index: net/base/upload_data_stream.h
===================================================================
--- net/base/upload_data_stream.h	(revision 145640)
+++ net/base/upload_data_stream.h	(working copy)
@@ -65,10 +65,16 @@
   // Returns true if the upload data in the stream is entirely in memory.
   bool IsInMemory() const;
 
-  // This method is provided only to be used by unit tests.
+ private:
+  friend class SpdyHttpStreamSpdy2Test;
+  friend class SpdyHttpStreamSpdy3Test;
+  friend class SpdyNetworkTransactionSpdy2Test;
+  friend class SpdyNetworkTransactionSpdy3Test;
+
+  // These methods are provided only to be used by unit tests.
+  static bool merge_chunks() { return merge_chunks_; }

[Ryan Hamilton, 2012/07/09 17:52:02]

Instead of making exposing this method, and having each of the four tests call
it, save away the state, and then call set_merge_chunks() with this saved value,
you might consider adding a method like ResetMergeChunks (or some such) which
resets this value to the default.  This would be similar to what we do with
SpdySession.

[ramant (doing other things), 2012/07/11 01:36:18]

Done.

   static void set_merge_chunks(bool merge) { merge_chunks_ = merge; }
 
- private:
   scoped_refptr<UploadData> upload_data_;
 
   // Index of the current upload element (i.e. the element currently being