SPDY - chunked upload - speech recognition doesn't work with SPDY/3

net/spdy/spdy_stream_spdy2_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/memory/ref_counted.h"
 #include "net/base/completion_callback.h"
 #include "net/base/net_log_unittest.h"
 #include "net/spdy/buffered_spdy_framer.h"
 #include "net/spdy/spdy_stream.h"
 #include "net/spdy/spdy_http_utils.h"
@@ skipping 29 matching lines @@
   }
   virtual int OnSendBody() {
     ADD_FAILURE() << "OnSendBody should not be called";
     return ERR_UNEXPECTED;
   }
   virtual int OnSendBodyComplete(int /*status*/, bool* /*eof*/) {
     ADD_FAILURE() << "OnSendBodyComplete should not be called";
     return ERR_UNEXPECTED;
   }
 
+  virtual int OnSendChunkedBody() {
+    ADD_FAILURE() << "OnSendChunkedBody should not be called";
+    return ERR_UNEXPECTED;
+  }
+  virtual int OnSendChunkedBodyComplete(int /*status*/, bool* /*eof*/) {
+    ADD_FAILURE() << "OnSendChunkedBodyComplete should not be called";
+    return ERR_UNEXPECTED;
+  }
+
   virtual int OnResponseReceived(const SpdyHeaderBlock& response,
                                  base::Time response_time,
                                  int status) {
     EXPECT_TRUE(send_headers_completed_);
     *response_ = response;
     if (buf_) {
       EXPECT_EQ(ERR_IO_PENDING,
                 stream_->WriteStreamData(buf_.get(), buf_->size(),
                                          DATA_FLAG_NONE));
     }
     return status;
   }
   virtual void OnDataReceived(const char* buffer, int bytes) {
     received_data_ += std::string(buffer, bytes);
   }
   virtual void OnDataSent(int length) {
     data_sent_ += length;
   }
   virtual void OnClose(int status) {
     closed_ = true;
     CompletionCallback callback = callback_;
     callback_.Reset();
     callback.Run(OK);
   }
   virtual void set_chunk_callback(net::ChunkCallback *) {}
+  virtual bool IsRequestBodyChunked() { return false; }

[Ryan Hamilton, 2012/07/02 22:34:32]

Should we add a test where this returns true?

[ramant (doing other things), 2012/07/04 21:04:33]

Deleted this code (because it is not needed).

 
   bool send_headers_completed() const { return send_headers_completed_; }
   const linked_ptr<SpdyHeaderBlock>& response() const {
     return response_;
   }
   const std::string& received_data() const { return received_data_; }
   int data_sent() const { return data_sent_; }
   bool closed() const {  return closed_; }
 
  private:
@@ skipping 344 matching lines @@
       entries, 0,
       net::NetLog::TYPE_SPDY_STREAM_ERROR,
       net::NetLog::PHASE_NONE);
 
   int stream_id2;
   ASSERT_TRUE(entries[pos].GetIntegerValue("stream_id", &stream_id2));
   EXPECT_EQ(static_cast<int>(stream_id), stream_id2);
 }
 
 }  // namespace net