SPDY - chunked upload - speech recognition doesn't work with SPDY/3

net/base/upload_data_stream.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef NET_BASE_UPLOAD_DATA_STREAM_H_
 #define NET_BASE_UPLOAD_DATA_STREAM_H_
 #pragma once
 
 #include "base/memory/ref_counted.h"
 #include "net/base/net_export.h"
@@ skipping 47 matching lines @@
 
   bool is_chunked() const { return upload_data_->is_chunked(); }
 
   // Returns true if all data has been consumed from this upload data
   // stream.
   bool IsEOF() const;
 
   // Returns true if the upload data in the stream is entirely in memory.
   bool IsInMemory() const;
 
   // This method is provided only to be used by unit tests.

[Ryan Sleevi, 2012/07/06 20:20:03]

nit: This method is -> These methods are

However, I'd suggest you make these private and either friend the
forward-declared unit test fixtures directly (SpdyHttpStreamSpdy[2/3]Test and
SpdyNetworkTransactionSpdy[2/3]test). Since individual tests derive from the
base class, you would need to expose a protected method on the test fixtures
that called these private methods.

Still, better than exposing these publicly, I think.

[ramant (doing other things), 2012/07/06 22:55:42]

Done.

+  static bool merge_chunks() { return merge_chunks_; }
   static void set_merge_chunks(bool merge) { merge_chunks_ = merge; }
 
  private:
   scoped_refptr<UploadData> upload_data_;
 
   // Index of the current upload element (i.e. the element currently being
   // read). The index is used as a cursor to iterate over elements in
   // |upload_data_|.
   size_t element_index_;
 
   // Size and current read position within the upload data stream.
   uint64 total_size_;
   uint64 current_position_;
 
   // True if the initialization was successful.
   bool initialized_successfully_;
 
   // TODO(satish): Remove this once we have a better way to unit test POST
   // requests with chunked uploads.
   static bool merge_chunks_;
 
   DISALLOW_COPY_AND_ASSIGN(UploadDataStream);
 };
 
 }  // namespace net
 
 #endif  // NET_BASE_UPLOAD_DATA_STREAM_H_