Chromium Code Reviews Chromium Code Reviews
Issue 10679009:
Revision to CPM UI using Flot and JQuery (Closed)
Base URL: http://git.chromium.org/chromium/src.git@master| Index: chrome/browser/resources/performance_monitor/chart.html |
| diff --git a/chrome/browser/resources/performance_monitor/chart.html b/chrome/browser/resources/performance_monitor/chart.html |
| index 7fb795de16d94fcb1a9a59f3523980c195d81785..773e9aae9f97a176aab0f8f18bc06377031ff1e9 100644 |
| --- a/chrome/browser/resources/performance_monitor/chart.html |
| +++ b/chrome/browser/resources/performance_monitor/chart.html |
| @@ -4,9 +4,17 @@ |
| Use of this source code is governed by a BSD-style license that can be |
| found in the LICENSE file. --> |
| +<!-- This page uses Flot version 0.7 in compressed form for efficiency. |
| +Readable Flot source is available at http://code.google.com/p/flot/ |
| +Good caliber Flot API docs are at: http://people.iola.dk/olau/flot/API.txt |
| +as of 6/2012 --> |
| + |
| <html> |
| <head> |
| - <script type="text/javascript" src="https://www.google.com/jsapi"></script> |
| + <script type="text/javascript" |
| + src="../../../../third_party/flot/jquery.min.js"> </script> |
|
Dan Beam
2012/06/28 21:39:14
nit: no space before </script>
|
| + <script type="text/javascript" |
| + src="../../../../third_party/flot/jquery.flot.min.js"></script> |
| <link rel="stylesheet" type="text/css" href="chart.css"/> |
| </head> |
| <body> |
| @@ -23,6 +31,8 @@ found in the LICENSE file. --> |
| </div> |
| <div id="charts"></div> |
| <div id="templates" class="hidden"> |
| + <div id="labelTemplate" class="event-label"> |
|
Dan Beam
2012/06/28 21:39:14
nit: move </div> to end of same line
clintstaley
2012/06/29 22:34:20
Done, though I did this intentionally because the
|
| + </div> |
| <div id="checkboxTemplate" class="checkbox"> |
| <label> |
| <input type="checkbox"></input> |
