chrome/browser/sync/sync_global_error.cc - Issue 10677009: Move command handling and updating off Browser and onto a helper object.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/sync/sync_global_error.cc

Issue 10677009: Move command handling and updating off Browser and onto a helper object. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/

Patch Set: Created 8 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/sync/sync_global_error.cc

===================================================================

--- chrome/browser/sync/sync_global_error.cc (revision 144460)

+++ chrome/browser/sync/sync_global_error.cc (working copy)

@@ -9,6 +9,7 @@

#include "chrome/browser/sync/profile_sync_service_observer.h"

#include "chrome/browser/sync/sync_ui_util.h"

#include "chrome/browser/ui/browser.h"

+#include "chrome/browser/ui/browser_commands.h"

#include "chrome/browser/ui/global_error_service.h"

#include "chrome/browser/ui/global_error_service_factory.h"

#include "chrome/browser/ui/webui/signin/login_ui_service.h"

@@ -59,7 +60,8 @@

#if defined(OS_CHROMEOS)

if (service_->GetAuthError().state() != AuthError::NONE) {

DLOG(INFO) << "Signing out the user to fix a sync error.";

- browser->ExecuteCommand(IDC_EXIT);

+ // TODO(beng): seems like this could just call browser::AttemptUserExit().

+ chrome::ExecuteCommand(browser, IDC_EXIT);

return;

}

#endif

« no previous file with comments | « chrome/browser/ssl/ssl_browser_tests.cc ('k') | chrome/browser/sync/sync_global_error_unittest.cc » ('j') | no next file with comments »