chrome/browser/download/save_page_browsertest.cc - Issue 10677009: Move command handling and updating off Browser and onto a helper object.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/download/save_page_browsertest.cc

Issue 10677009: Move command handling and updating off Browser and onto a helper object. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/

Patch Set: Created 8 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/command_updater.h ('K') | « chrome/browser/command_updater_unittest.cc ('k') | chrome/browser/extensions/extension_global_error_badge.cc » ('j') | chrome/browser/ui/browser.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/download/save_page_browsertest.cc

===================================================================

--- chrome/browser/download/save_page_browsertest.cc (revision 144216)

+++ chrome/browser/download/save_page_browsertest.cc (working copy)

@@ -284,8 +284,7 @@

IN_PROC_BROWSER_TEST_F(SavePageBrowserTest, NoSave) {

ui_test_utils::NavigateToURL(browser(), GURL(chrome::kAboutBlankURL));

- ASSERT_TRUE(browser()->command_updater()->SupportsCommand(IDC_SAVE_PAGE));

- EXPECT_FALSE(browser()->command_updater()->IsCommandEnabled(IDC_SAVE_PAGE));

+ EXPECT_FALSE(chrome::CanSavePage(browser()));

}

IN_PROC_BROWSER_TEST_F(SavePageBrowserTest, FileNameFromPageTitle) {