Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 10673018: Add HostEventLogger to It2Me host plugin (Closed)

Created:
8 years, 5 months ago by Lambros
Modified:
8 years, 5 months ago
CC:
chromium-reviews, jamiewalch+watch_chromium.org, dcaiafa+watch_chromium.org, simonmorris+watch_chromium.org, hclam+watch_chromium.org, wez+watch_chromium.org, amit, sanjeevr, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, alexeypa+watch_chromium.org, sergeyu+watch_chromium.org
Visibility:
Public.

Description

Add HostEventLogger to It2Me host plugin BUG=132886 TEST=Manual

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -27 lines) Patch
M remoting/host/plugin/host_script_object.h View 2 chunks +2 lines, -0 lines 0 comments Download
M remoting/host/plugin/host_script_object.cc View 4 chunks +6 lines, -0 lines 1 comment Download
M remoting/remoting.gyp View 6 chunks +27 lines, -27 lines 1 comment Download

Messages

Total messages: 3 (0 generated)
Lambros
alexeypa: Please look at Windows changes to remoting.gyp - I don't have a Win box ...
8 years, 5 months ago (2012-07-19 01:31:17 UTC) #1
alexeypa (please no reviews)
http://codereview.chromium.org/10673018/diff/1/remoting/host/plugin/host_script_object.cc File remoting/host/plugin/host_script_object.cc (right): http://codereview.chromium.org/10673018/diff/1/remoting/host/plugin/host_script_object.cc#newcode587 remoting/host/plugin/host_script_object.cc:587: host_event_logger_ = HostEventLogger::Create(host_, kApplicationName); This is not going to ...
8 years, 5 months ago (2012-07-19 17:05:00 UTC) #2
Lambros
8 years, 5 months ago (2012-07-19 23:05:04 UTC) #3
On 2012/07/19 17:05:00, alexeypa wrote:
>
http://codereview.chromium.org/10673018/diff/1/remoting/host/plugin/host_scri...
> File remoting/host/plugin/host_script_object.cc (right):
> 
>
http://codereview.chromium.org/10673018/diff/1/remoting/host/plugin/host_scri...
> remoting/host/plugin/host_script_object.cc:587: host_event_logger_ =
> HostEventLogger::Create(host_, kApplicationName);
> This is not going to work on Windows. Logging to the Event Log requires an
event
> source to be registered in the registry (per machine). For me2me host it is
done
> by the installer. it2me host on the other hand:
> 
> - Does not have admin privileges.
> - Is installed per-user.
> 
> http://codereview.chromium.org/10673018/diff/1/remoting/remoting.gyp
> File remoting/remoting.gyp (right):
> 
>
http://codereview.chromium.org/10673018/diff/1/remoting/remoting.gyp#newcode1285
> remoting/remoting.gyp:1285: 'host/remoting_host_messages.mc',
> This should work, but it is a little bit tricky. The binaries including
> remoting_host as a dependency will suddenly get the message table compiled
from
> remoting_host_messages.mc. The potential complications that I see are:
> 
> - There will be a comflict if a binary wants to use its own message table.
> - The binary should be registered in the registry if it's message table is
being
> used to display messages in the Event Log.

OK, I'll abandon this CL for now, as I can't do the Windows work we've
discussed.  Alexey, please feel free to start a new CL and incorporate whatever
changes you want from this CL.

Powered by Google App Engine
This is Rietveld 408576698