base/threading/thread_checker_unittest.cc - Issue 10673010: Don't rely on undefined macro behaviour in unit tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/threading/thread_checker_unittest.cc

Issue 10673010: Don't rely on undefined macro behaviour in unit tests. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 8 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: base/threading/thread_checker_unittest.cc

diff --git a/base/threading/thread_checker_unittest.cc b/base/threading/thread_checker_unittest.cc

index 0dadcf01f0e8ddaa3fc85540ce5826f561902452..5e44d370d43137bb51f85f1b6897689433c50312 100644

--- a/base/threading/thread_checker_unittest.cc

+++ b/base/threading/thread_checker_unittest.cc

@@ -11,7 +11,11 @@

// Duplicated from base/threading/thread_checker.h so that we can be

// good citizens there and undef the macro.

-#define ENABLE_THREAD_CHECKER (!defined(NDEBUG) || defined(DCHECK_ALWAYS_ON))

+#if (!defined(NDEBUG) || defined(DCHECK_ALWAYS_ON))

jar (doing other things) 2012/06/26 23:02:40 nit: You don't need the outer parens

+#define ENABLE_THREAD_CHECKER 1

+#else

+#define ENABLE_THREAD_CHECKER 0

+#endif

namespace base {

« no previous file with comments | « no previous file | no next file » | no next file with comments »