Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1335)

Unified Diff: content/content_shell.gypi

Issue 10669030: Pass the build type to ant build (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: Rebase Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/shell/content_shell_ant_helper.sh » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/content_shell.gypi
diff --git a/content/content_shell.gypi b/content/content_shell.gypi
index dc29d48e7cdfda6e325c5b9d8579033e4a0a76d1..841ab57b3fff69370ff0ccb270a35f8e0c423c2b 100644
--- a/content/content_shell.gypi
+++ b/content/content_shell.gypi
@@ -586,8 +586,8 @@
{
'action_name': 'content_shell_apk',
'inputs': [
- '<(DEPTH)/content/shell/android/java/content_shell_apk.xml',
- '<(DEPTH)/content/shell/android/java/AndroidManifest.xml',
+ 'shell/android/java/content_shell_apk.xml',
+ 'shell/android/java/AndroidManifest.xml',
'<!@(find shell/android/java -name "*.java")',
'<!@(find shell/android/res -name "*")',
'<(PRODUCT_DIR)/content_shell/java/libs/chromium_base.jar',
@@ -605,11 +605,16 @@
'<(PRODUCT_DIR)/content_shell/ContentShell-debug.apk',
],
'action': [
+ # Pass the build type to ant. Currently it only assumes
+ # debug mode in java. Release mode will break the current
+ # workflow.
+ # 'shell/content_shell_ant_helper.sh',
'ant',
'-DPRODUCT_DIR=<(ant_build_out)',
'-DAPP_ABI=<(android_app_abi)',
'-buildfile',
- '<(DEPTH)/content/shell/android/java/content_shell_apk.xml',
+ 'shell/android/java/content_shell_apk.xml',
+ # '<(CONFIGURATION_NAME)',
]
}
],
« no previous file with comments | « no previous file | content/shell/content_shell_ant_helper.sh » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698