Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(757)

Unified Diff: content/content_shell.gypi

Issue 10669030: Pass the build type to ant build (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: Refine the patch according to jrg's comments Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/android/content_shell_ant_helper.sh ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/content_shell.gypi
diff --git a/content/content_shell.gypi b/content/content_shell.gypi
index 599d5f2e006b978560d3203ee784e1982a5b7ada..b1b708efd90d023811d8c824dc075ce5e915196f 100644
--- a/content/content_shell.gypi
+++ b/content/content_shell.gypi
@@ -567,11 +567,18 @@
'<(PRODUCT_DIR)/ContentShell-debug.apk',
],
'action': [
+ # Pass the build type to ant. Currently it only assumes
+ # debug mode in java. Release mode will break the current
+ # workflow.
+ # TODO(yongsheng): enable it once the workflow is ready
+ # to support release mode.
+ # '<(DEPTH)/build/android/content_shell_ant_helper.sh',
'ant',
'-DPRODUCT_DIR=<(ant_build_out)',
'-DAPP_ABI=<(android_app_abi)',
'-buildfile',
'<(DEPTH)/content/shell/android/content_shell_apk.xml',
+ # '<(CONFIGURATION_NAME)',
jochen (gone - plz use gerrit) 2012/07/10 09:14:24 What about disabling this (i.e. replacing the last
yongsheng 2012/07/10 11:25:45 It's also ok for me. I'll change it. Thanks.
]
}
],
« no previous file with comments | « build/android/content_shell_ant_helper.sh ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698