build/android/content_shell_ant_helper.sh - Issue 10669030: Pass the build type to ant build

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: build/android/content_shell_ant_helper.sh

Issue 10669030: Pass the build type to ant build (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk

Patch Set: Refine the patch according to jochen's comments Created 8 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 #!/bin/bash

	2

	3 # Copyright (c) 2012 The Chromium Authors. All rights reserved.

	4 # Use of this source code is governed by a BSD-style license that can be

	5 # found in the LICENSE file.

	6

	7 set -eu

	8

	9 # A helper script to help convert the values of the fifth parameter for

	10 # ant building: 'Debug' -> 'debug'; 'Release' -> 'release'.

	11 # It's used by content/content_shell.gypi
	Mark Mentovai 2012/07/10 12:21:37 Then why does it live here in some far-off directo Then why does it live here in some far-off directory, instead of next to content_shell.gypi? Will this be useful for any other part of the build in the short or even medium term? John Grabowski 2012/07/10 14:16:05 Because I suggested he move it? There are no othe Show quoted text On 2012/07/10 12:21:37, Mark Mentovai wrote: > Then why does it live here in some far-off directory, instead of next to > content_shell.gypi? Will this be useful for any other part of the build in the > short or even medium term? Because I suggested he move it? There are no other scripts in the content/ directory. I think you and I are asking for opposite things here.
	12

	13 buildtype="$(tr '[A-Z]' '[a-z]' <<< "${6}")"

	14

	15 # TODO(yongsheng): enable build type by adding "${buildtype}" into the

	16 # end of parameter list once the workflow is ready to support release

	17 # mode.

	18 exec "${1}" "${2}" "${3}" "${4}" "${5}"

OLD	NEW

« no previous file with comments | « no previous file | content/content_shell.gypi » ('j') | no next file with comments »