Pass the build type to ant build

content/content_shell.gypi

 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 {
   'variables': {
     'content_shell_product_name': 'Content Shell',
   },
   'targets': [
     {
@@ skipping 530 matching lines @@
               'action': [
                 '<!(/bin/echo -n $STRIP)',
                 '--strip-unneeded',  # All symbols not needed for relocation.
                 '<@(_inputs)',
                 '-o',
                 '<@(_outputs)' 
               ],
             },
             {
               'action_name': 'content_shell_apk',
+              'variables': {
+                # Pass the build type to ant. Currently it only assumes
+                # debug mode in java. Release mode will break the current
+                # workflow.
+                # TODO(yongsheng): enable it once the workflow is ready
+                # to support release mode.
+                # 'ant_build_type%': '`if [ "<(CONFIGURATION_NAME)" = "Debug" ]; then echo "debug"; elif [ "<(CONFIGURATION_NAME)" = "Release" ]; then echo "release"; fi;`',

[John Grabowski, 2012/06/26 19:30:37]

<!(cmd) instead of backticks

[yongsheng, 2012/06/27 03:36:04]

seems not workable. Because the gyp will execute it when generating .mk file.
However, this command could only run when making.

[John Grabowski, 2012/06/27 16:45:58]

Can you explain why it's a problem in a mk file?

+              },
               'inputs': [
                 '<(DEPTH)/content/shell/android/content_shell_apk.xml',
                 '<(DEPTH)/content/shell/android/AndroidManifest.xml',
                 '<!@(find shell/android/java -name "*.java")',
                 '<!@(find shell/android/res -name "*")',
                 '<(PRODUCT_DIR)/content_shell/java/libs/chromium_base.jar',
                 '<(PRODUCT_DIR)/content_shell/java/libs/chromium_net.jar',
                 '<(PRODUCT_DIR)/content_shell/java/libs/chromium_media.jar',
                 '<(PRODUCT_DIR)/content_shell/java/libs/chromium_content.jar',
                 '<(PRODUCT_DIR)/content_shell/libs/<(android_app_abi)/libcontent_shell_content_view.so',
               ],
               'outputs': [
                 # Awkwardly, we build a Debug APK even when gyp is in
                 # Release mode.  I don't think it matters (e.g. we're
                 # probably happy to not codesign) but naming should be
                 # fixed.
                 '<(PRODUCT_DIR)/ContentShell-debug.apk',
               ],
               'action': [
                 'ant',
                 '-DPRODUCT_DIR=<(ant_build_out)',
                 '-DAPP_ABI=<(android_app_abi)',
                 '-buildfile',
                 '<(DEPTH)/content/shell/android/content_shell_apk.xml',
+                # '<(ant_build_type)',

[Mark Mentovai, 2012/06/28 14:24:18]

Why not just <(CONFIGURATION_NAME) here? It’s awful to depend on shell behavior
here and in ant_build_type. If ant can’t deal with Release and Debug with
capital letters, have this action call a helper script that transforms the
argument appropriately. That’s guaranteed to work. Writing shell garbage into an
action spec like this is not guaranteed to work. In fact, it shouldn’t work, and
if it does, it only does with certain generators and is buggy.

[yongsheng, 2012/06/29 02:01:46]

Thanks for your comments.
How about replacing it with the below code?
`echo <(CONFIGURATION_NAME) | tr "[A-Z]" "[a-z]"`
It uses `` instead of '<!(cmd)' for it should execute it when doing make. 
Actually, i follow up another parameter in this action. See below: 
'-DPRODUCT_DIR=<(ant_build_out)'
Here is the definition of 'ant_build_out':
build/common.gypi:865:        'ant_build_out': '`cd <(PRODUCT_DIR) && pwd -P`',
I verified that they all work. 
make sense?

[Mark Mentovai, 2012/06/29 02:03:54]

Again, backticks aren’t guaranteed to work. I gave you my advice earlier today.

[yongsheng, 2012/06/29 02:08:21]

yes, i see. Thanks. If it doesn't work, any hint about your suggestion for the
'helper script'?

[Mark Mentovai, 2012/06/29 03:20:18]

#!/bin/bash
set -eu
buildtype="$(tr '[A-Z]' '[a-z]' <<< "${5}")"
exec "${1}" "${2}" "${3}" "${4}" "${buildtype}"

               ]
             }
           ],
         },
       ],
     }],  # OS=="android"
   ]
 }