Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(440)

Unified Diff: media/filters/gpu_video_decoder.cc

Issue 10669022: Add status parameter to DemuxerStream::ReadCB (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix seek_tester build buster Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/filters/gpu_video_decoder.cc
diff --git a/media/filters/gpu_video_decoder.cc b/media/filters/gpu_video_decoder.cc
index 7415db87ac0bb4b4513313a1683fbfc82ea49a8c..00f93ad39dfa9206bc390a9e460d228e064554ad 100644
--- a/media/filters/gpu_video_decoder.cc
+++ b/media/filters/gpu_video_decoder.cc
@@ -200,20 +200,27 @@ void GpuVideoDecoder::Read(const ReadCB& read_cb) {
}
void GpuVideoDecoder::RequestBufferDecode(
+ DemuxerStream::Status status,
const scoped_refptr<DecoderBuffer>& buffer) {
+ DCHECK_EQ(status != DemuxerStream::kOk, !buffer);
Ami GONE FROM CHROMIUM 2012/07/12 17:10:26 ditto << status
acolwell GONE FROM CHROMIUM 2012/07/12 21:59:58 Done.
+
if (!gvd_loop_proxy_->BelongsToCurrentThread()) {
gvd_loop_proxy_->PostTask(FROM_HERE, base::Bind(
- &GpuVideoDecoder::RequestBufferDecode, this, buffer));
+ &GpuVideoDecoder::RequestBufferDecode, this, status, buffer));
return;
}
demuxer_read_in_progress_ = false;
- if (!buffer) {
+ if (status != DemuxerStream::kOk) {
if (pending_read_cb_.is_null())
return;
+ // TODO(acolwell): Add support for reinitializing the decoder when
+ // |status| == kConfigChanged. For now we just trigger a decode error.
+ DecoderStatus decoder_status =
+ (status == DemuxerStream::kAborted) ? kOk : kDecodeError;
gvd_loop_proxy_->PostTask(FROM_HERE, base::Bind(
- pending_read_cb_, kOk, scoped_refptr<VideoFrame>()));
+ pending_read_cb_, decoder_status, scoped_refptr<VideoFrame>()));
pending_read_cb_.Reset();
return;
}

Powered by Google App Engine
This is Rietveld 408576698