chrome/browser/ui/webui/downloads_dom_handler.cc - Issue 10665049: Make DownloadHistory observe manager, items

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/downloads_dom_handler.cc

Issue 10665049: Make DownloadHistory observe manager, items (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: . Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/webui/downloads_dom_handler.cc

diff --git a/chrome/browser/ui/webui/downloads_dom_handler.cc b/chrome/browser/ui/webui/downloads_dom_handler.cc

index 6b331f70a6e6854734f5e067ba568bb1766c349b..888315f188a2075eff2e42715164870e835ee787 100644

--- a/chrome/browser/ui/webui/downloads_dom_handler.cc

+++ b/chrome/browser/ui/webui/downloads_dom_handler.cc

@@ -362,7 +362,6 @@ void DownloadsDOMHandler::ModelChanged(content::DownloadManager* manager) {

// We should never see anything that isn't already in the history.

DCHECK(*it);

- DCHECK((*it)->IsPersisted());

(*it)->AddObserver(this);

}

@@ -450,7 +449,6 @@ void DownloadsDOMHandler::HandleRemove(const ListValue* args) {

CountDownloadsDOMEvents(DOWNLOADS_DOM_EVENT_REMOVE);

content::DownloadItem* file = GetDownloadByValue(args);

if (file) {

- DCHECK(file->IsPersisted());

file->Remove();

}