chrome/browser/ui/gtk/download/download_item_gtk.cc - Issue 10665049: Make DownloadHistory observe manager, items

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/gtk/download/download_item_gtk.cc

Issue 10665049: Make DownloadHistory observe manager, items (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: . Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/gtk/download/download_item_gtk.cc

diff --git a/chrome/browser/ui/gtk/download/download_item_gtk.cc b/chrome/browser/ui/gtk/download/download_item_gtk.cc

index b10831c8101a35501c143e3996e1678b2e764002..107e676dad972a2d3cc44c20779376fc6b11e8ce 100644

--- a/chrome/browser/ui/gtk/download/download_item_gtk.cc

+++ b/chrome/browser/ui/gtk/download/download_item_gtk.cc

@@ -468,6 +468,7 @@ void DownloadItemGtk::LoadIcon() {

icon_consumer_.CancelAllRequests();

IconManager* im = g_browser_process->icon_manager();

icon_filepath_ = get_download()->GetUserVerifiedFilePath();

+ if (icon_filepath_.empty()) return;

Randy Smith (Not in Mondays) 2012/08/28 13:11:49 Is this really part of this CL?

benjhayden 2012/09/10 19:02:56 Done.

im->LoadIcon(icon_filepath_,

IconLoader::SMALL, &icon_consumer_,

base::Bind(&DownloadItemGtk::OnLoadSmallIconComplete,