Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1436)

Unified Diff: content/browser/download/download_manager_impl_unittest.cc

Issue 10665049: Make DownloadHistory observe manager, items (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: . Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/download/download_manager_impl_unittest.cc
diff --git a/content/browser/download/download_manager_impl_unittest.cc b/content/browser/download/download_manager_impl_unittest.cc
index 545c414120d9296a2dc8923b9e310200a889e5f0..4dcf03e67b842cf912ab6947392e4670048111ac 100644
--- a/content/browser/download/download_manager_impl_unittest.cc
+++ b/content/browser/download/download_manager_impl_unittest.cc
@@ -157,9 +157,6 @@ class MockDownloadItemImpl : public DownloadItemImpl {
MOCK_METHOD0(OffThreadCancel, void());
MOCK_CONST_METHOD1(DebugString, std::string(bool));
MOCK_METHOD0(MockDownloadOpenForTesting, void());
- MOCK_METHOD1(GetExternalData, ExternalData*(const void*));
- MOCK_CONST_METHOD1(GetExternalData, const ExternalData*(const void*));
- MOCK_METHOD2(SetExternalData, void(const void*, ExternalData*));
};
class MockDownloadManagerDelegate : public content::DownloadManagerDelegate {
@@ -178,13 +175,6 @@ class MockDownloadManagerDelegate : public content::DownloadManagerDelegate {
DownloadItem*, const base::Closure&));
MOCK_METHOD1(ShouldOpenDownload, bool(DownloadItem*));
MOCK_METHOD0(GenerateFileHash, bool());
- MOCK_METHOD1(AddItemToPersistentStore, void(DownloadItem*));
- MOCK_METHOD1(UpdateItemInPersistentStore, void(DownloadItem*));
- MOCK_METHOD2(UpdatePathForItemInPersistentStore,
- void(DownloadItem*, const FilePath&));
- MOCK_METHOD1(RemoveItemFromPersistentStore, void(DownloadItem*));
- MOCK_METHOD2(RemoveItemsFromPersistentStoreBetween, void(
- base::Time remove_begin, base::Time remove_end));
MOCK_METHOD4(GetSaveDir, void(WebContents*, FilePath*, FilePath*, bool*));
MOCK_METHOD5(ChooseSavePath, void(
WebContents*, const FilePath&, const FilePath::StringType&,
@@ -641,16 +631,12 @@ TEST_F(DownloadManagerTest, OnDownloadStopped_Persisted) {
MockDownloadItemImpl& item(AddItemToManager());
int download_id = item.GetId();
int64 db_handle = 0x7;
- EXPECT_CALL(item, GetExternalData(_))
- .WillOnce(Return(static_cast<DownloadItem::ExternalData*>(NULL)));
EXPECT_CALL(GetMockObserver(), ModelChanged(download_manager_.get()))
.WillOnce(Return());
AddItemToHistory(item, db_handle);
EXPECT_CALL(item, IsPersisted())
.WillRepeatedly(Return(true));
- EXPECT_CALL(GetMockDownloadManagerDelegate(),
- UpdateItemInPersistentStore(&item));
EXPECT_CALL(item, GetState())
.WillRepeatedly(Return(DownloadItem::CANCELLED));
EXPECT_CALL(item, GetDbHandle())

Powered by Google App Engine
This is Rietveld 408576698