Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8157)

Unified Diff: chrome/browser/ui/cocoa/download/download_item_mac.mm

Issue 10665049: Make DownloadHistory observe manager, items (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: . Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/download/download_item_mac.mm
diff --git a/chrome/browser/ui/cocoa/download/download_item_mac.mm b/chrome/browser/ui/cocoa/download/download_item_mac.mm
index b5dc9b6323ceb0be7470b8bd1b8f2d8e9de44e96..3a622b46361c8aff6367ec68f4c4d58272dc8867 100644
--- a/chrome/browser/ui/cocoa/download/download_item_mac.mm
+++ b/chrome/browser/ui/cocoa/download/download_item_mac.mm
@@ -46,9 +46,6 @@ void DownloadItemMac::OnDownloadUpdated(content::DownloadItem* download) {
}
switch (download->GetState()) {
- case DownloadItem::REMOVING:
- [item_controller_ remove]; // We're deleted now!
- break;
case DownloadItem::COMPLETE:
if (download->GetAutoOpened()) {
[item_controller_ remove]; // We're deleted now!
@@ -69,6 +66,10 @@ void DownloadItemMac::OnDownloadUpdated(content::DownloadItem* download) {
}
}
+void DownloadItemMac::OnDownloadDestroyed(content::DownloadItem* download) {
+ [item_controller_ remove]; // We're deleted now!
+}
+
void DownloadItemMac::OnDownloadOpened(content::DownloadItem* download) {
DCHECK_EQ(download, download_model_->download());
[item_controller_ downloadWasOpened];

Powered by Google App Engine
This is Rietveld 408576698