Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(208)

Side by Side Diff: chrome/browser/download/download_browsertest.cc

Issue 10665049: Make DownloadHistory observe manager, items (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: . Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <sstream> 5 #include <sstream>
6 6
7 #include "base/bind.h" 7 #include "base/bind.h"
8 #include "base/bind_helpers.h" 8 #include "base/bind_helpers.h"
9 #include "base/file_path.h" 9 #include "base/file_path.h"
10 #include "base/file_util.h" 10 #include "base/file_util.h"
(...skipping 10 matching lines...) Expand all
21 #include "chrome/browser/download/chrome_download_manager_delegate.h" 21 #include "chrome/browser/download/chrome_download_manager_delegate.h"
22 #include "chrome/browser/download/download_crx_util.h" 22 #include "chrome/browser/download/download_crx_util.h"
23 #include "chrome/browser/download/download_history.h" 23 #include "chrome/browser/download/download_history.h"
24 #include "chrome/browser/download/download_prefs.h" 24 #include "chrome/browser/download/download_prefs.h"
25 #include "chrome/browser/download/download_request_limiter.h" 25 #include "chrome/browser/download/download_request_limiter.h"
26 #include "chrome/browser/download/download_shelf.h" 26 #include "chrome/browser/download/download_shelf.h"
27 #include "chrome/browser/download/download_test_file_chooser_observer.h" 27 #include "chrome/browser/download/download_test_file_chooser_observer.h"
28 #include "chrome/browser/download/download_util.h" 28 #include "chrome/browser/download/download_util.h"
29 #include "chrome/browser/extensions/extension_install_prompt.h" 29 #include "chrome/browser/extensions/extension_install_prompt.h"
30 #include "chrome/browser/extensions/extension_service.h" 30 #include "chrome/browser/extensions/extension_service.h"
31 #include "chrome/browser/history/download_persistent_store_info.h"
31 #include "chrome/browser/history/history.h" 32 #include "chrome/browser/history/history.h"
32 #include "chrome/browser/history/history_service_factory.h" 33 #include "chrome/browser/history/history_service_factory.h"
33 #include "chrome/browser/net/url_request_mock_util.h" 34 #include "chrome/browser/net/url_request_mock_util.h"
34 #include "chrome/browser/prefs/pref_service.h" 35 #include "chrome/browser/prefs/pref_service.h"
35 #include "chrome/browser/profiles/profile.h" 36 #include "chrome/browser/profiles/profile.h"
36 #include "chrome/browser/tab_contents/render_view_context_menu.h" 37 #include "chrome/browser/tab_contents/render_view_context_menu.h"
37 #include "chrome/browser/ui/browser.h" 38 #include "chrome/browser/ui/browser.h"
38 #include "chrome/browser/ui/browser_commands.h" 39 #include "chrome/browser/ui/browser_commands.h"
39 #include "chrome/browser/ui/browser_list.h" 40 #include "chrome/browser/ui/browser_list.h"
40 #include "chrome/browser/ui/browser_tabstrip.h" 41 #include "chrome/browser/ui/browser_tabstrip.h"
41 #include "chrome/browser/ui/browser_window.h" 42 #include "chrome/browser/ui/browser_window.h"
42 #include "chrome/browser/ui/chrome_pages.h" 43 #include "chrome/browser/ui/chrome_pages.h"
43 #include "chrome/common/chrome_notification_types.h" 44 #include "chrome/common/chrome_notification_types.h"
44 #include "chrome/common/chrome_paths.h" 45 #include "chrome/common/chrome_paths.h"
45 #include "chrome/common/extensions/extension_switch_utils.h" 46 #include "chrome/common/extensions/extension_switch_utils.h"
46 #include "chrome/common/pref_names.h" 47 #include "chrome/common/pref_names.h"
47 #include "chrome/common/url_constants.h" 48 #include "chrome/common/url_constants.h"
48 #include "chrome/test/base/in_process_browser_test.h" 49 #include "chrome/test/base/in_process_browser_test.h"
49 #include "chrome/test/base/ui_test_utils.h" 50 #include "chrome/test/base/ui_test_utils.h"
50 #include "content/public/browser/download_item.h" 51 #include "content/public/browser/download_item.h"
51 #include "content/public/browser/download_manager.h" 52 #include "content/public/browser/download_manager.h"
52 #include "content/public/browser/download_persistent_store_info.h"
53 #include "content/public/browser/download_save_info.h" 53 #include "content/public/browser/download_save_info.h"
54 #include "content/public/browser/download_url_parameters.h" 54 #include "content/public/browser/download_url_parameters.h"
55 #include "content/public/browser/notification_source.h" 55 #include "content/public/browser/notification_source.h"
56 #include "content/public/browser/render_view_host.h" 56 #include "content/public/browser/render_view_host.h"
57 #include "content/public/browser/resource_context.h" 57 #include "content/public/browser/resource_context.h"
58 #include "content/public/browser/web_contents.h" 58 #include "content/public/browser/web_contents.h"
59 #include "content/public/common/context_menu_params.h" 59 #include "content/public/common/context_menu_params.h"
60 #include "content/public/common/page_transition_types.h" 60 #include "content/public/common/page_transition_types.h"
61 #include "content/public/test/browser_test_utils.h" 61 #include "content/public/test/browser_test_utils.h"
62 #include "content/public/test/download_test_observer.h" 62 #include "content/public/test/download_test_observer.h"
63 #include "content/public/test/test_file_error_injector.h" 63 #include "content/public/test/test_file_error_injector.h"
64 #include "content/public/test/test_navigation_observer.h" 64 #include "content/public/test/test_navigation_observer.h"
65 #include "content/test/net/url_request_mock_http_job.h" 65 #include "content/test/net/url_request_mock_http_job.h"
66 #include "content/test/net/url_request_slow_download_job.h" 66 #include "content/test/net/url_request_slow_download_job.h"
67 #include "net/base/net_util.h" 67 #include "net/base/net_util.h"
68 #include "net/test/test_server.h" 68 #include "net/test/test_server.h"
69 #include "testing/gtest/include/gtest/gtest.h" 69 #include "testing/gtest/include/gtest/gtest.h"
70 70
71 using content::BrowserContext; 71 using content::BrowserContext;
72 using content::BrowserThread; 72 using content::BrowserThread;
73 using content::DownloadItem; 73 using content::DownloadItem;
74 using content::DownloadManager; 74 using content::DownloadManager;
75 using content::DownloadPersistentStoreInfo;
76 using content::DownloadUrlParameters; 75 using content::DownloadUrlParameters;
77 using content::WebContents; 76 using content::WebContents;
78 using extensions::Extension; 77 using extensions::Extension;
79 78
80 namespace { 79 namespace {
81 80
82 // IDs and paths of CRX files used in tests. 81 // IDs and paths of CRX files used in tests.
83 const char kGoodCrxId[] = "ldnnhddmnhbkjipkidpdiheffobcpfmf"; 82 const char kGoodCrxId[] = "ldnnhddmnhbkjipkidpdiheffobcpfmf";
84 const FilePath kGoodCrxPath(FILE_PATH_LITERAL("extensions/good.crx")); 83 const FilePath kGoodCrxPath(FILE_PATH_LITERAL("extensions/good.crx"));
85 84
86 const char kLargeThemeCrxId[] = "pjpgmfcmabopnnfonnhmdjglfpjjfkbf"; 85 const char kLargeThemeCrxId[] = "pjpgmfcmabopnnfonnhmdjglfpjjfkbf";
87 const FilePath kLargeThemePath(FILE_PATH_LITERAL("extensions/theme2.crx")); 86 const FilePath kLargeThemePath(FILE_PATH_LITERAL("extensions/theme2.crx"));
88 87
89 // Get History Information.
90 class DownloadsHistoryDataCollector {
91 public:
92 DownloadsHistoryDataCollector(int64 download_db_handle,
93 DownloadManager* manager)
94 : result_valid_(false),
95 download_db_handle_(download_db_handle) {
96 HistoryService* hs = HistoryServiceFactory::GetForProfile(
97 Profile::FromBrowserContext(manager->GetBrowserContext()),
98 Profile::EXPLICIT_ACCESS);
99 DCHECK(hs);
100 hs->QueryDownloads(
101 &callback_consumer_,
102 base::Bind(&DownloadsHistoryDataCollector::OnQueryDownloadsComplete,
103 base::Unretained(this)));
104
105 // TODO(rdsmith): Move message loop out of constructor.
106 // Cannot complete immediately because the history backend runs on a
107 // separate thread, so we can assume that the RunMessageLoop below will
108 // be exited by the Quit in OnQueryDownloadsComplete.
109 content::RunMessageLoop();
110 }
111
112 bool GetDownloadsHistoryEntry(DownloadPersistentStoreInfo* result) {
113 DCHECK(result);
114 *result = result_;
115 return result_valid_;
116 }
117
118 private:
119 void OnQueryDownloadsComplete(
120 std::vector<DownloadPersistentStoreInfo>* entries) {
121 result_valid_ = false;
122 for (std::vector<DownloadPersistentStoreInfo>::const_iterator it =
123 entries->begin();
124 it != entries->end(); ++it) {
125 if (it->db_handle == download_db_handle_) {
126 result_ = *it;
127 result_valid_ = true;
128 }
129 }
130 MessageLoopForUI::current()->Quit();
131 }
132
133 DownloadPersistentStoreInfo result_;
134 bool result_valid_;
135 int64 download_db_handle_;
136 CancelableRequestConsumer callback_consumer_;
137
138 DISALLOW_COPY_AND_ASSIGN(DownloadsHistoryDataCollector);
139 };
140
141 // Mock that simulates a permissions dialog where the user denies 88 // Mock that simulates a permissions dialog where the user denies
142 // permission to install. TODO(skerner): This could be shared with 89 // permission to install. TODO(skerner): This could be shared with
143 // extensions tests. Find a common place for this class. 90 // extensions tests. Find a common place for this class.
144 class MockAbortExtensionInstallPrompt : public ExtensionInstallPrompt { 91 class MockAbortExtensionInstallPrompt : public ExtensionInstallPrompt {
145 public: 92 public:
146 MockAbortExtensionInstallPrompt() : ExtensionInstallPrompt(NULL, NULL, NULL) { 93 MockAbortExtensionInstallPrompt() : ExtensionInstallPrompt(NULL, NULL, NULL) {
147 } 94 }
148 95
149 // Simulate a user abort on an extension installation. 96 // Simulate a user abort on an extension installation.
150 virtual void ConfirmInstall(Delegate* delegate, const Extension* extension) { 97 virtual void ConfirmInstall(Delegate* delegate, const Extension* extension) {
(...skipping 39 matching lines...) Expand 10 before | Expand all | Expand 10 after
190 private: 137 private:
191 virtual void PlatformInit() {} 138 virtual void PlatformInit() {}
192 virtual void PlatformCancel() {} 139 virtual void PlatformCancel() {}
193 virtual bool GetAcceleratorForCommandId(int, ui::Accelerator*) { 140 virtual bool GetAcceleratorForCommandId(int, ui::Accelerator*) {
194 return false; 141 return false;
195 } 142 }
196 143
197 DISALLOW_COPY_AND_ASSIGN(TestRenderViewContextMenu); 144 DISALLOW_COPY_AND_ASSIGN(TestRenderViewContextMenu);
198 }; 145 };
199 146
147 typedef std::vector<DownloadPersistentStoreInfo> InfoVector;
148
149 void HistoryQueryCallbackOnUI(
150 InfoVector* out,
151 scoped_ptr<InfoVector> in) {
152 in->swap(*out);
153 MessageLoop::current()->Quit();
154 }
155
156 void HistoryQueryCallbackOnDB(
157 InfoVector* out,
158 scoped_ptr<InfoVector> in) {
159 BrowserThread::PostTask(BrowserThread::UI, FROM_HERE,
160 base::Bind(&HistoryQueryCallbackOnUI, out, base::Passed(in.Pass())));
161 }
162
200 } // namespace 163 } // namespace
201 164
202 // While an object of this class exists, it will mock out download 165 // While an object of this class exists, it will mock out download
203 // opening for all downloads created on the specified download manager. 166 // opening for all downloads created on the specified download manager.
204 class MockDownloadOpeningObserver : public DownloadManager::Observer { 167 class MockDownloadOpeningObserver : public DownloadManager::Observer {
205 public: 168 public:
206 explicit MockDownloadOpeningObserver(DownloadManager* manager) 169 explicit MockDownloadOpeningObserver(DownloadManager* manager)
207 : download_manager_(manager) { 170 : download_manager_(manager) {
208 download_manager_->AddObserver(this); 171 download_manager_->AddObserver(this);
209 } 172 }
(...skipping 648 matching lines...) Expand 10 before | Expand all | Expand 10 after
858 821
859 // Download the file and wait. We do not expect the Select File dialog. 822 // Download the file and wait. We do not expect the Select File dialog.
860 DownloadAndWait(browser(), url); 823 DownloadAndWait(browser(), url);
861 824
862 // Check state. 825 // Check state.
863 EXPECT_EQ(1, browser()->tab_count()); 826 EXPECT_EQ(1, browser()->tab_count());
864 CheckDownload(browser(), file, file); 827 CheckDownload(browser(), file, file);
865 EXPECT_TRUE(browser()->window()->IsDownloadShelfVisible()); 828 EXPECT_TRUE(browser()->window()->IsDownloadShelfVisible());
866 } 829 }
867 830
831 IN_PROC_BROWSER_TEST_F(DownloadTest, DownloadHistory) {
832 FilePath file(FILE_PATH_LITERAL("download-test1.lib"));
833 GURL url(URLRequestMockHTTPJob::GetMockUrl(file));
834 HistoryService* hs = HistoryServiceFactory::GetForProfile(
835 browser()->profile(), Profile::EXPLICIT_ACCESS);
836 InfoVector infos;
837 hs->QueryDownloads(base::Bind(&HistoryQueryCallbackOnDB, &infos));
838 MessageLoop::current()->Run();
839 EXPECT_EQ(0, static_cast<int>(infos.size()));
840
841 // Download the file and wait. We do not expect the Select File dialog.
842 DownloadAndWait(browser(), url);
843 CheckDownload(browser(), file, file);
844
845 DownloadManager* manager = DownloadManagerForBrowser(browser());
846 DownloadManager::DownloadVector downloads;
847 manager->SearchDownloads(string16(), &downloads);
848 EXPECT_EQ(1, static_cast<int>(downloads.size()));
849
850 hs->QueryDownloads(base::Bind(&HistoryQueryCallbackOnDB, &infos));
851 MessageLoop::current()->Run();
852 EXPECT_EQ(1, static_cast<int>(infos.size()));
853 EXPECT_EQ(downloads[0]->GetFullPath().value(), infos[0].path.value());
854 EXPECT_EQ(url.spec(), infos[0].url.spec());
855 EXPECT_EQ("", infos[0].referrer_url.spec());
856 EXPECT_EQ(downloads[0]->GetStartTime().ToTimeT(),
857 infos[0].start_time.ToTimeT());
858 EXPECT_EQ(downloads[0]->GetEndTime().ToTimeT(), infos[0].end_time.ToTimeT());
859 EXPECT_EQ(downloads[0]->GetReceivedBytes(), infos[0].received_bytes);
860 EXPECT_EQ(downloads[0]->GetTotalBytes(), infos[0].total_bytes);
861 EXPECT_EQ(DownloadItem::COMPLETE, infos[0].state);
862 EXPECT_EQ(1, infos[0].db_handle);
863 EXPECT_EQ(false, infos[0].opened);
864
865 downloads[0]->MockDownloadOpenForTesting();
866 downloads[0]->OpenDownload();
867 EXPECT_TRUE(downloads[0]->GetOpened());
868 hs->QueryDownloads(base::Bind(&HistoryQueryCallbackOnDB, &infos));
869 MessageLoop::current()->Run();
870 EXPECT_EQ(1, static_cast<int>(infos.size()));
871 EXPECT_EQ(1, infos[0].db_handle);
872 EXPECT_EQ(true, infos[0].opened);
873 }
874
868 #if defined(OS_WIN) 875 #if defined(OS_WIN)
869 // Download a file and confirm that the zone identifier (on windows) 876 // Download a file and confirm that the zone identifier (on windows)
870 // is set to internet. 877 // is set to internet.
871 IN_PROC_BROWSER_TEST_F(DownloadTest, CheckInternetZone) { 878 IN_PROC_BROWSER_TEST_F(DownloadTest, CheckInternetZone) {
872 FilePath file(FILE_PATH_LITERAL("download-test1.lib")); 879 FilePath file(FILE_PATH_LITERAL("download-test1.lib"));
873 GURL url(URLRequestMockHTTPJob::GetMockUrl(file)); 880 GURL url(URLRequestMockHTTPJob::GetMockUrl(file));
874 881
875 // Download the file and wait. We do not expect the Select File dialog. 882 // Download the file and wait. We do not expect the Select File dialog.
876 DownloadAndWait(browser(), url); 883 DownloadAndWait(browser(), url);
877 884
(...skipping 644 matching lines...) Expand 10 before | Expand all | Expand 10 after
1522 1529
1523 // Get the important info from other threads and check it. 1530 // Get the important info from other threads and check it.
1524 EXPECT_TRUE(EnsureNoPendingDownloads()); 1531 EXPECT_TRUE(EnsureNoPendingDownloads());
1525 1532
1526 // Using "DownloadItem::Remove" follows the discard dangerous download path, 1533 // Using "DownloadItem::Remove" follows the discard dangerous download path,
1527 // which completely removes the browser from the shelf and closes the shelf 1534 // which completely removes the browser from the shelf and closes the shelf
1528 // if it was there. Download panel stays open on ChromeOS. 1535 // if it was there. Download panel stays open on ChromeOS.
1529 EXPECT_FALSE(browser()->window()->IsDownloadShelfVisible()); 1536 EXPECT_FALSE(browser()->window()->IsDownloadShelfVisible());
1530 } 1537 }
1531 1538
1532 // Confirm a download makes it into the history properly.
1533 IN_PROC_BROWSER_TEST_F(DownloadTest, DownloadHistoryCheck) {
1534 FilePath file(FILE_PATH_LITERAL("download-test1.lib"));
1535 GURL url(URLRequestMockHTTPJob::GetMockUrl(file));
1536 FilePath origin_file(OriginFile(file));
1537 int64 origin_size;
1538 file_util::GetFileSize(origin_file, &origin_size);
1539
1540 // Download the file and wait. We do not expect the Select File dialog.
1541 DownloadAndWait(browser(), url);
1542
1543 // Get details of what downloads have just happened.
1544 std::vector<DownloadItem*> downloads;
1545 GetDownloads(browser(), &downloads);
1546 ASSERT_EQ(1u, downloads.size());
1547 int64 db_handle = downloads[0]->GetDbHandle();
1548
1549 // Check state.
1550 EXPECT_EQ(1, browser()->tab_count());
1551 CheckDownload(browser(), file, file);
1552 EXPECT_TRUE(browser()->window()->IsDownloadShelfVisible());
1553
1554 // Check history results.
1555 DownloadsHistoryDataCollector history_collector(
1556 db_handle,
1557 DownloadManagerForBrowser(browser()));
1558 DownloadPersistentStoreInfo info;
1559 EXPECT_TRUE(history_collector.GetDownloadsHistoryEntry(&info)) << db_handle;
1560 EXPECT_EQ(file, info.path.BaseName());
1561 EXPECT_EQ(url, info.url);
1562 // Ignore start_time.
1563 EXPECT_EQ(origin_size, info.received_bytes);
1564 EXPECT_EQ(origin_size, info.total_bytes);
1565 EXPECT_EQ(DownloadItem::COMPLETE, info.state);
1566 }
1567
1568 // Test for crbug.com/14505. This tests that chrome:// urls are still functional 1539 // Test for crbug.com/14505. This tests that chrome:// urls are still functional
1569 // after download of a file while viewing another chrome://. 1540 // after download of a file while viewing another chrome://.
1570 IN_PROC_BROWSER_TEST_F(DownloadTest, ChromeURLAfterDownload) { 1541 IN_PROC_BROWSER_TEST_F(DownloadTest, ChromeURLAfterDownload) {
1571 FilePath file(FILE_PATH_LITERAL("download-test1.lib")); 1542 FilePath file(FILE_PATH_LITERAL("download-test1.lib"));
1572 GURL download_url(URLRequestMockHTTPJob::GetMockUrl(file)); 1543 GURL download_url(URLRequestMockHTTPJob::GetMockUrl(file));
1573 GURL flags_url(chrome::kChromeUIFlagsURL); 1544 GURL flags_url(chrome::kChromeUIFlagsURL);
1574 GURL extensions_url(chrome::kChromeUIExtensionsFrameURL); 1545 GURL extensions_url(chrome::kChromeUIExtensionsFrameURL);
1575 1546
1576 ui_test_utils::NavigateToURL(browser(), flags_url); 1547 ui_test_utils::NavigateToURL(browser(), flags_url);
1577 DownloadAndWait(browser(), download_url); 1548 DownloadAndWait(browser(), download_url);
(...skipping 231 matching lines...) Expand 10 before | Expand all | Expand 10 after
1809 1780
1810 // Download shelf should close. Download panel stays open on ChromeOS. 1781 // Download shelf should close. Download panel stays open on ChromeOS.
1811 EXPECT_FALSE(browser()->window()->IsDownloadShelfVisible()); 1782 EXPECT_FALSE(browser()->window()->IsDownloadShelfVisible());
1812 1783
1813 // Check that the extension was installed. 1784 // Check that the extension was installed.
1814 ExtensionService* extension_service = 1785 ExtensionService* extension_service =
1815 browser()->profile()->GetExtensionService(); 1786 browser()->profile()->GetExtensionService();
1816 ASSERT_TRUE(extension_service->GetExtensionById(kLargeThemeCrxId, false)); 1787 ASSERT_TRUE(extension_service->GetExtensionById(kLargeThemeCrxId, false));
1817 } 1788 }
1818 1789
1819 // Sort download items by db_handle. 1790 // Sort download items by id.
1820 static bool DownloadItemSorter(DownloadItem* d1, DownloadItem* d2) { 1791 static bool DownloadItemSorter(DownloadItem* d1, DownloadItem* d2) {
1821 return d1->GetDbHandle() < d2->GetDbHandle(); 1792 return d1->GetId() < d2->GetId();
1822 } 1793 }
1823 1794
1824 // Confirm that searching through the history works properly 1795 // Confirm that searching through the history works properly
1825 IN_PROC_BROWSER_TEST_F(DownloadTest, SearchDownloads) { 1796 IN_PROC_BROWSER_TEST_F(DownloadTest, SearchDownloads) {
1826 // Downloads to populate history with.
1827 base::Time current(base::Time::Now());
1828 DownloadPersistentStoreInfo population_entries[] = {
1829 DownloadPersistentStoreInfo(
1830 FilePath(FILE_PATH_LITERAL("/path/to/file")),
1831 GURL("http://www.google.com/fantasy_download"),
1832 GURL(""),
1833 current - base::TimeDelta::FromMinutes(5),
1834 current,
1835 128,
1836 128,
1837 DownloadItem::COMPLETE,
1838 1,
1839 false),
1840 DownloadPersistentStoreInfo(
1841 FilePath(FILE_PATH_LITERAL("/path/to/another_file")),
1842 GURL("http://www.google.com/reality_download"),
1843 GURL(""),
1844 current - base::TimeDelta::FromMinutes(10),
1845 current,
1846 256,
1847 256,
1848 DownloadItem::COMPLETE,
1849 2,
1850 false),
1851 DownloadPersistentStoreInfo(
1852 FilePath(FILE_PATH_LITERAL("/different_path/to/another_file")),
1853 GURL("http://www.izzle.com/not_really_a_download"),
1854 GURL(""),
1855 current - base::TimeDelta::FromMinutes(15),
1856 current,
1857 512,
1858 512,
1859 DownloadItem::COMPLETE,
1860 3,
1861 true)
1862 };
1863 std::vector<DownloadPersistentStoreInfo> entries(
1864 population_entries, population_entries + arraysize(population_entries));
1865
1866 // Populate the manager. 1797 // Populate the manager.
1867 DownloadManager* manager = DownloadManagerForBrowser(browser()); 1798 DownloadManager* manager = DownloadManagerForBrowser(browser());
1868 manager->OnPersistentStoreQueryComplete(&entries); 1799 base::Time current(base::Time::Now());
1800 manager->CreateDownloadItem(
1801 FilePath(FILE_PATH_LITERAL("/path/to/file")),
1802 GURL("http://www.google.com/fantasy_download"),
1803 GURL(""),
1804 current - base::TimeDelta::FromMinutes(5),
1805 current,
1806 128,
1807 128,
1808 DownloadItem::COMPLETE,
1809 false);
1810 manager->CreateDownloadItem(
1811 FilePath(FILE_PATH_LITERAL("/path/to/another_file")),
1812 GURL("http://www.google.com/reality_download"),
1813 GURL(""),
1814 current - base::TimeDelta::FromMinutes(10),
1815 current,
1816 256,
1817 256,
1818 DownloadItem::COMPLETE,
1819 false);
1820 manager->CreateDownloadItem(
1821 FilePath(FILE_PATH_LITERAL("/different_path/to/another_file")),
1822 GURL("http://www.izzle.com/not_really_a_download"),
1823 GURL(""),
1824 current - base::TimeDelta::FromMinutes(15),
1825 current,
1826 512,
1827 512,
1828 DownloadItem::COMPLETE,
1829 true);
1869 1830
1870 // Do some searches and check the results. 1831 // Do some searches and check the results.
1871 std::vector<DownloadItem*> search_results; 1832 std::vector<DownloadItem*> search_results;
1872 1833
1873 manager->SearchDownloads(string16(), &search_results); 1834 manager->SearchDownloads(string16(), &search_results);
1874 ASSERT_EQ(3u, search_results.size()); 1835 ASSERT_EQ(3u, search_results.size());
1875 std::sort(search_results.begin(), search_results.end(), 1836 std::sort(search_results.begin(), search_results.end(),
1876 DownloadItemSorter); 1837 DownloadItemSorter);
1877 // We do a full check only once to protect against the data 1838 // We do a full check only once to protect against the data
1878 // somehow getting scrambled on its way into the DownloadItems. 1839 // somehow getting scrambled on its way into the DownloadItems.
1879 { 1840 {
1880 DownloadItem* d1 = search_results[0]; 1841 DownloadItem* d1 = search_results[0];
1881 DownloadItem* d2 = search_results[1]; 1842 DownloadItem* d2 = search_results[1];
1882 DownloadItem* d3 = search_results[2]; 1843 DownloadItem* d3 = search_results[2];
1883 EXPECT_EQ(FilePath(FILE_PATH_LITERAL("/path/to/file")), d1->GetFullPath()); 1844 EXPECT_EQ(FilePath(FILE_PATH_LITERAL("/path/to/file")), d1->GetFullPath());
1884 EXPECT_EQ(GURL("http://www.google.com/fantasy_download"), 1845 EXPECT_EQ(GURL("http://www.google.com/fantasy_download"),
1885 d1->GetOriginalUrl()); 1846 d1->GetOriginalUrl());
1886 EXPECT_EQ(current - base::TimeDelta::FromMinutes(5), 1847 EXPECT_EQ(current - base::TimeDelta::FromMinutes(5),
1887 d1->GetStartTime()); 1848 d1->GetStartTime());
1888 EXPECT_EQ(current, d1->GetEndTime()); 1849 EXPECT_EQ(current, d1->GetEndTime());
1889 EXPECT_EQ(128, d1->GetReceivedBytes()); 1850 EXPECT_EQ(128, d1->GetReceivedBytes());
1890 EXPECT_EQ(128, d1->GetTotalBytes()); 1851 EXPECT_EQ(128, d1->GetTotalBytes());
1891 EXPECT_EQ(DownloadItem::COMPLETE, d1->GetState()); 1852 EXPECT_EQ(DownloadItem::COMPLETE, d1->GetState());
1892 EXPECT_EQ(1, d1->GetDbHandle());
1893 EXPECT_FALSE(d1->GetOpened()); 1853 EXPECT_FALSE(d1->GetOpened());
1894 1854
1895 EXPECT_EQ(FilePath(FILE_PATH_LITERAL("/path/to/another_file")), 1855 EXPECT_EQ(FilePath(FILE_PATH_LITERAL("/path/to/another_file")),
1896 d2->GetFullPath()); 1856 d2->GetFullPath());
1897 EXPECT_EQ(GURL("http://www.google.com/reality_download"), 1857 EXPECT_EQ(GURL("http://www.google.com/reality_download"),
1898 d2->GetOriginalUrl()); 1858 d2->GetOriginalUrl());
1899 EXPECT_EQ(current - base::TimeDelta::FromMinutes(10), 1859 EXPECT_EQ(current - base::TimeDelta::FromMinutes(10),
1900 d2->GetStartTime()); 1860 d2->GetStartTime());
1901 EXPECT_EQ(current, d2->GetEndTime()); 1861 EXPECT_EQ(current, d2->GetEndTime());
1902 EXPECT_EQ(256, d2->GetReceivedBytes()); 1862 EXPECT_EQ(256, d2->GetReceivedBytes());
1903 EXPECT_EQ(256, d2->GetTotalBytes()); 1863 EXPECT_EQ(256, d2->GetTotalBytes());
1904 EXPECT_EQ(DownloadItem::COMPLETE, d2->GetState()); 1864 EXPECT_EQ(DownloadItem::COMPLETE, d2->GetState());
1905 EXPECT_EQ(2, d2->GetDbHandle());
1906 EXPECT_FALSE(d2->GetOpened()); 1865 EXPECT_FALSE(d2->GetOpened());
1907 1866
1908 EXPECT_EQ(FilePath(FILE_PATH_LITERAL("/different_path/to/another_file")), 1867 EXPECT_EQ(FilePath(FILE_PATH_LITERAL("/different_path/to/another_file")),
1909 d3->GetFullPath()); 1868 d3->GetFullPath());
1910 EXPECT_EQ(GURL("http://www.izzle.com/not_really_a_download"), 1869 EXPECT_EQ(GURL("http://www.izzle.com/not_really_a_download"),
1911 d3->GetOriginalUrl()); 1870 d3->GetOriginalUrl());
1912 EXPECT_EQ(current - base::TimeDelta::FromMinutes(15), 1871 EXPECT_EQ(current - base::TimeDelta::FromMinutes(15),
1913 d3->GetStartTime()); 1872 d3->GetStartTime());
1914 EXPECT_EQ(current, d3->GetEndTime()); 1873 EXPECT_EQ(current, d3->GetEndTime());
1915 EXPECT_EQ(512, d3->GetReceivedBytes()); 1874 EXPECT_EQ(512, d3->GetReceivedBytes());
1916 EXPECT_EQ(512, d3->GetTotalBytes()); 1875 EXPECT_EQ(512, d3->GetTotalBytes());
1917 EXPECT_EQ(DownloadItem::COMPLETE, d3->GetState()); 1876 EXPECT_EQ(DownloadItem::COMPLETE, d3->GetState());
1918 EXPECT_EQ(3, d3->GetDbHandle());
1919 EXPECT_TRUE(d3->GetOpened()); 1877 EXPECT_TRUE(d3->GetOpened());
1920 } 1878 }
1921 search_results.clear(); 1879 search_results.clear();
1922 1880
1923 string16 search_input; 1881 string16 search_input;
1924 manager->SearchDownloads(UTF8ToUTF16("www.google.com"), &search_results); 1882 manager->SearchDownloads(UTF8ToUTF16("www.google.com"), &search_results);
1925 ASSERT_EQ(2u, search_results.size()); 1883 ASSERT_EQ(2u, search_results.size());
1926 std::sort(search_results.begin(), search_results.end(), 1884 std::sort(search_results.begin(), search_results.end(),
1927 DownloadItemSorter); 1885 DownloadItemSorter);
1928 EXPECT_EQ(1, search_results[0]->GetDbHandle());
1929 EXPECT_EQ(2, search_results[1]->GetDbHandle());
1930 search_results.clear(); 1886 search_results.clear();
1931 1887
1932 manager->SearchDownloads(UTF8ToUTF16("real"), &search_results); 1888 manager->SearchDownloads(UTF8ToUTF16("real"), &search_results);
1933 ASSERT_EQ(2u, search_results.size()); 1889 ASSERT_EQ(2u, search_results.size());
1934 std::sort(search_results.begin(), search_results.end(), 1890 std::sort(search_results.begin(), search_results.end(),
1935 DownloadItemSorter); 1891 DownloadItemSorter);
1936 EXPECT_EQ(2, search_results[0]->GetDbHandle());
1937 EXPECT_EQ(3, search_results[1]->GetDbHandle());
1938 search_results.clear(); 1892 search_results.clear();
1939 1893
1940 manager->SearchDownloads(UTF8ToUTF16("another_file"), &search_results); 1894 manager->SearchDownloads(UTF8ToUTF16("another_file"), &search_results);
1941 ASSERT_EQ(2u, search_results.size()); 1895 ASSERT_EQ(2u, search_results.size());
1942 std::sort(search_results.begin(), search_results.end(), 1896 std::sort(search_results.begin(), search_results.end(),
1943 DownloadItemSorter); 1897 DownloadItemSorter);
1944 EXPECT_EQ(2, search_results[0]->GetDbHandle());
1945 EXPECT_EQ(3, search_results[1]->GetDbHandle());
1946 search_results.clear(); 1898 search_results.clear();
1947 } 1899 }
1948 1900
1949 // Tests for download initiation functions. 1901 // Tests for download initiation functions.
1950 IN_PROC_BROWSER_TEST_F(DownloadTest, DownloadUrl) { 1902 IN_PROC_BROWSER_TEST_F(DownloadTest, DownloadUrl) {
1951 FilePath file(FILE_PATH_LITERAL("download-test1.lib")); 1903 FilePath file(FILE_PATH_LITERAL("download-test1.lib"));
1952 GURL url(URLRequestMockHTTPJob::GetMockUrl(file)); 1904 GURL url(URLRequestMockHTTPJob::GetMockUrl(file));
1953 1905
1954 // DownloadUrl always prompts; return acceptance of whatever it prompts. 1906 // DownloadUrl always prompts; return acceptance of whatever it prompts.
1955 EnableFileChooser(true); 1907 EnableFileChooser(true);
(...skipping 513 matching lines...) Expand 10 before | Expand all | Expand 10 after
2469 GetDownloads(browser(), &download_items); 2421 GetDownloads(browser(), &download_items);
2470 ASSERT_EQ(1u, download_items.size()); 2422 ASSERT_EQ(1u, download_items.size());
2471 ASSERT_EQ(test_server()->GetURL("echoheader?Referer"), 2423 ASSERT_EQ(test_server()->GetURL("echoheader?Referer"),
2472 download_items[0]->GetOriginalUrl()); 2424 download_items[0]->GetOriginalUrl());
2473 2425
2474 // Check that the file contains the expected referrer. 2426 // Check that the file contains the expected referrer.
2475 FilePath file(download_items[0]->GetFullPath()); 2427 FilePath file(download_items[0]->GetFullPath());
2476 std::string expected_contents = test_server()->GetURL("").spec(); 2428 std::string expected_contents = test_server()->GetURL("").spec();
2477 ASSERT_TRUE(VerifyFile(file, expected_contents, expected_contents.length())); 2429 ASSERT_TRUE(VerifyFile(file, expected_contents, expected_contents.length()));
2478 } 2430 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698