Implement installation of the Chrome App Host.

chrome/installer/mini_installer/mini_installer.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.

[grt (UTC plus 2), 2012/07/12 18:37:10]

2012

[erikwright (departed), 2012/07/16 20:13:11]

Done.

 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // mini_installer.exe is the first exe that is run when chrome is being
 // installed or upgraded. It is designed to be extremely small (~5KB with no
 // extra resources linked) and it has two main jobs:
 //   1) unpack the resources (possibly decompressing some)
 //   2) run the real installer (setup.exe) with appropriate flags.
 //
 // In order to be really small the app doesn't link against the CRT and
 // defines the following compiler/linker flags:
 //   EnableIntrinsicFunctions="true" compiler: /Oi
 //   BasicRuntimeChecks="0"
 //   BufferSecurityCheck="false" compiler: /GS-
 //   EntryPointSymbol="MainEntryPoint" linker: /ENTRY
 //   IgnoreAllDefaultLibraries="true" linker: /NODEFAULTLIB
 //   OptimizeForWindows98="1"  liker: /OPT:NOWIN98
 //   linker: /SAFESEH:NO
 
 // have the linker merge the sections, saving us ~500 bytes.
 #pragma comment(linker, "/MERGE:.rdata=.text")
 
 #include <windows.h>
 #include <shellapi.h>
+#include <wchar.h>

[tommi (sloooow) - chröme, 2012/07/12 08:11:31]

out of curiosity, why is this needed?

[erikwright (departed), 2012/07/16 20:13:11]

Extreme IWYU. Obviously too extreme.

Done.

[grt (UTC plus 2), 2012/07/23 11:31:12]

If you added it because the type wchar_t is used in this file, wchar_t is a
keyword in C++-03 so no includes are needed to use it.

 
 #include "chrome/installer/mini_installer/appid.h"
 #include "chrome/installer/mini_installer/configuration.h"
 #include "chrome/installer/mini_installer/decompress.h"
 #include "chrome/installer/mini_installer/mini_installer.h"
 #include "chrome/installer/mini_installer/mini_string.h"
 #include "chrome/installer/mini_installer/pe_resource.h"
 
 namespace mini_installer {
 
@@ skipping 116 matching lines @@
 // should try full installer next time. If the current installer works, this
 // flag is cleared by setup.exe at the end of install. The flag will by default
 // be written to HKCU, but if --system-level is included in the command line,
 // it will be written to HKLM instead.
 // TODO(grt): Write a unit test for this that uses registry virtualization.
 void SetInstallerFlags(const Configuration& configuration) {
   RegKey key;
   const REGSAM key_access = KEY_QUERY_VALUE | KEY_SET_VALUE;
   const HKEY root_key =
       configuration.is_system_level() ? HKEY_LOCAL_MACHINE : HKEY_CURRENT_USER;
+  // This is ignored if multi-install is true.
   const wchar_t* app_guid =
       configuration.has_chrome_frame() ?
           google_update::kChromeFrameAppGuid :
           configuration.chrome_app_guid();
   StackString<128> value;
   LONG ret;
 
   // When multi_install is true, we are potentially:
   // 1. Performing a multi-install of some product(s) on a clean machine.
   //    Neither the product(s) nor the multi-installer will have a ClientState
@@ skipping 49 matching lines @@
 }
 
 // Gets the setup.exe path from Registry by looking the value of Uninstall
 // string.  |size| is measured in wchar_t units.
 bool GetSetupExePathFromRegistry(const Configuration& configuration,
                                  wchar_t* path,
                                  size_t size) {
   const HKEY root_key =
       configuration.is_system_level() ? HKEY_LOCAL_MACHINE : HKEY_CURRENT_USER;
   RegKey key;
-  bool succeeded = false;
 
-  // If this is a multi install, first try looking in the binaries for the path.
-  if (configuration.is_multi_install() &&
-      OpenClientStateKey(root_key, google_update::kMultiInstallAppGuid,
-                         KEY_QUERY_VALUE, &key)) {
-    succeeded = (key.ReadValue(kUninstallRegistryValueName, path,
-                               size) == ERROR_SUCCESS);
+  const int kMaxGuids = 10;

[grt (UTC plus 2), 2012/07/12 18:37:10]

why not 4?

[erikwright (departed), 2012/07/16 20:13:11]

Done.

+  const wchar_t* app_guids[kMaxGuids] = {0};

[grt (UTC plus 2), 2012/07/12 18:37:10]

{0} -> {}

[erikwright (departed), 2012/07/16 20:13:11]

Done.

+  size_t guid_count = 0;
+
+  // If this is a multi install, first try looking in the binaries for the path

[grt (UTC plus 2), 2012/07/12 18:37:10]

"path" -> "path."

[erikwright (departed), 2012/07/16 20:13:11]

Done.

+  if (configuration.is_multi_install())
+    app_guids[guid_count++] = google_update::kMultiInstallAppGuid;
+  // Failing that, look in Chrome Frame's client state key --chrome-frame was

[grt (UTC plus 2), 2012/07/12 18:37:10]

"state key" -> "state key if"

[erikwright (departed), 2012/07/16 20:13:11]

Done.

+  // specified.
+  if (guid_count < kMaxGuids && configuration.has_chrome_frame())
+    app_guids[guid_count++] = google_update::kChromeFrameAppGuid;
+  // Make a last-ditch effort to look in the Chrome and App Host client state
+  // keys.
+  if (guid_count < kMaxGuids)
+    app_guids[guid_count++] = configuration.chrome_app_guid();
+  if (guid_count < kMaxGuids && configuration.has_app_host())
+    app_guids[guid_count++] = google_update::kChromeAppHostAppGuid;
+
+  for (size_t i = 0; i < guid_count; ++i) {
+    if (!OpenClientStateKey(root_key, app_guids[i], KEY_QUERY_VALUE, &key))
+      continue;
+
+    if (key.ReadValue(kUninstallRegistryValueName, path, size) == ERROR_SUCCESS)
+      return true;
   }
 
-  // Failing that, look in Chrome Frame's client state key --chrome-frame was
-  // specified.
-  if (!succeeded && configuration.has_chrome_frame() &&
-      OpenClientStateKey(root_key, google_update::kChromeFrameAppGuid,
-                         KEY_QUERY_VALUE, &key)) {
-    succeeded = (key.ReadValue(kUninstallRegistryValueName, path,
-                               size) == ERROR_SUCCESS);
-  }
-
-  // Make a last-ditch effort to look in Chrome's client state key.
-  if (!succeeded &&
-      OpenClientStateKey(root_key, configuration.chrome_app_guid(),
-                         KEY_QUERY_VALUE, &key)) {
-    succeeded = (key.ReadValue(kUninstallRegistryValueName, path,
-                               size) == ERROR_SUCCESS);
-  }
-
-  return succeeded;
+  return false;
 }
 
 // Calls CreateProcess with good default parameters and waits for the process
 // to terminate returning the process exit code.
 bool RunProcessAndWait(const wchar_t* exe_path, wchar_t* cmdline,
                        int* exit_code) {
   STARTUPINFOW si = {sizeof(si)};
   PROCESS_INFORMATION pi = {0};
   if (!::CreateProcess(exe_path, cmdline, NULL, NULL, FALSE, CREATE_NO_WINDOW,
                        NULL, NULL, &si, &pi)) {
@@ skipping 566 matching lines @@
     case 1:
       dest8[count - 1] = c;
   }
 
   while (adjcount-- > 0)  // Copy the rest, 4 bytes/32 bits at a time
     *(dest32++) = fill;
 
   return dest;
 }
 }  // extern "C"