Changing tab closure handling logic in speech recognition code and cleaning bubble controller. (Spe…

chrome/browser/speech/chrome_speech_recognition_manager_delegate.h

Index: chrome/browser/speech/chrome_speech_recognition_manager_delegate.h
diff --git a/chrome/browser/speech/chrome_speech_recognition_manager_delegate.h b/chrome/browser/speech/chrome_speech_recognition_manager_delegate.h
index eb1f4d5b8cc1aa36e32e62d5e56b06f14056f711..510685ae7a5c787e9dfc3b0e36caa4a96663aeec 100644
--- a/chrome/browser/speech/chrome_speech_recognition_manager_delegate.h
+++ b/chrome/browser/speech/chrome_speech_recognition_manager_delegate.h
@@ -14,9 +14,9 @@
 #include "content/public/browser/speech_recognition_session_config.h"
 
 class SpeechRecognitionTrayIconController;
+class TabWatcher;
 
 namespace speech {
-
 // This is Chrome's implementation of the SpeechRecognitionManagerDelegate
 // interface.
 class ChromeSpeechRecognitionManagerDelegate
@@ -80,6 +80,9 @@ class ChromeSpeechRecognitionManagerDelegate
   // (which is copied into |last_session_config_|). Used for "try again".
   void RestartLastSession();
 
+  // Callback called by |tab_watcher_| on the IO thread to notify tab closure.

[hans, 2012/06/26 13:10:44]

"to notify tab closure" doesn't sound quite right.. maybe "to signal tab
closure" is better?

[Primiano Tucci (use gerrit), 2012/06/26 14:27:07]

yup

+  void TabClosedCallback(int render_process_id, int render_view_id);
+
   // Lazy initializers for bubble and tray icon controller.
   SpeechRecognitionBubbleController* GetBubbleController();
   SpeechRecognitionTrayIconController* GetTrayIconController();
@@ -88,9 +91,7 @@ class ChromeSpeechRecognitionManagerDelegate
   scoped_refptr<SpeechRecognitionTrayIconController> tray_icon_controller_;
   scoped_refptr<OptionalRequestInfo> optional_request_info_;
   scoped_ptr<content::SpeechRecognitionSessionConfig> last_session_config_;
-
-  // TODO(primiano) this information should be kept into the bubble_controller_.
-  int active_bubble_session_id_;
+  scoped_refptr<TabWatcher> tab_watcher_;
 
   DISALLOW_COPY_AND_ASSIGN(ChromeSpeechRecognitionManagerDelegate);
 };