Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(789)

Issue 10663: Some debugging support fixes on ARM simulator port.... (Closed)

Created:
12 years, 1 month ago by Feng Qian
Modified:
9 years, 7 months ago
Reviewers:
iposva
CC:
v8-dev
Visibility:
Public.

Description

Some debugging support fixes on ARM simulator port. 1) Let SaveContext remember the top JS frame stack pointer so it works in simulator where C stack and JS stack are separated; 2) Use the new calling convension in %DebugBreakCallHelper function; Committed: http://code.google.com/p/v8/source/detail?r=774

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -40 lines) Patch
M src/builtins-arm.cc View 2 chunks +2 lines, -38 lines 0 comments Download
M src/runtime.cc View 1 2 2 chunks +3 lines, -2 lines 0 comments Download
M src/top.h View 1 2 2 chunks +10 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Feng Qian
12 years, 1 month ago (2008-11-12 23:53:30 UTC) #1
iposva
12 years, 1 month ago (2008-11-17 16:55:34 UTC) #2
LGTM -ip

Powered by Google App Engine
This is Rietveld 408576698