Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(191)

Side by Side Diff: content/browser/renderer_host/media/media_stream_manager.h

Issue 10662049: Move the device enumerate/open/close work to device thread from IO thread (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: addressed Andrew and John's comments. Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // MediaStreamManager is used to open/enumerate media capture devices (video 5 // MediaStreamManager is used to open/enumerate media capture devices (video
6 // supported now). Call flow: 6 // supported now). Call flow:
7 // 1. GenerateStream is called when a render process wants to use a capture 7 // 1. GenerateStream is called when a render process wants to use a capture
8 // device. 8 // device.
9 // 2. MediaStreamManager will ask MediaStreamDeviceSettings for permission to 9 // 2. MediaStreamManager will ask MediaStreamDeviceSettings for permission to
10 // use devices and for which device to use. 10 // use devices and for which device to use.
(...skipping 12 matching lines...) Expand all
23 #define CONTENT_BROWSER_RENDERER_HOST_MEDIA_MEDIA_STREAM_MANAGER_H_ 23 #define CONTENT_BROWSER_RENDERER_HOST_MEDIA_MEDIA_STREAM_MANAGER_H_
24 24
25 #include <map> 25 #include <map>
26 #include <string> 26 #include <string>
27 #include <vector> 27 #include <vector>
28 28
29 #include "base/basictypes.h" 29 #include "base/basictypes.h"
30 #include "base/memory/scoped_ptr.h" 30 #include "base/memory/scoped_ptr.h"
31 #include "base/memory/ref_counted.h" 31 #include "base/memory/ref_counted.h"
32 #include "base/supports_user_data.h" 32 #include "base/supports_user_data.h"
33 #include "base/threading/thread.h"
33 #include "content/browser/renderer_host/media/media_stream_provider.h" 34 #include "content/browser/renderer_host/media/media_stream_provider.h"
34 #include "content/browser/renderer_host/media/media_stream_settings_requester.h" 35 #include "content/browser/renderer_host/media/media_stream_settings_requester.h"
35 #include "content/common/media/media_stream_options.h" 36 #include "content/common/media/media_stream_options.h"
36 #include "content/common/content_export.h" 37 #include "content/common/content_export.h"
38 #include "content/public/browser/browser_thread.h"
37 39
38 namespace content { 40 namespace content {
39 class ResourceContext; 41 class ResourceContext;
40 } 42 }
41 43
42 namespace media {
43 class AudioManager;
44 }
45
46 namespace media_stream { 44 namespace media_stream {
47 45
48 class AudioInputDeviceManager; 46 class AudioInputDeviceManager;
49 class MediaStreamDeviceSettings; 47 class MediaStreamDeviceSettings;
50 class MediaStreamRequester; 48 class MediaStreamRequester;
51 class VideoCaptureManager; 49 class VideoCaptureManager;
52 50
53 // MediaStreamManager is used to generate and close new media devices, not to 51 // MediaStreamManager is used to generate and close new media devices, not to
54 // start the media flow. 52 // start the media flow.
55 // The classes requesting new media streams are answered using 53 // The classes requesting new media streams are answered using
56 // MediaStreamManager::Listener. 54 // MediaStreamManager::Listener.
57 class CONTENT_EXPORT MediaStreamManager 55 class CONTENT_EXPORT MediaStreamManager
58 : public MediaStreamProviderListener, 56 : public MediaStreamProviderListener,
59 public SettingsRequester, 57 public SettingsRequester,
60 public base::SupportsUserData::Data { 58 public base::SupportsUserData::Data {
61 public: 59 public:
62 // Returns the MediaStreamManager for the given ResourceContext. If it hasn't 60 // Returns the MediaStreamManager for the given ResourceContext. If it hasn't
63 // been created yet, it will be constructed with the given AudioManager. 61 // been created yet, it will be constructed with the given AudioManager.
64 static MediaStreamManager* GetForResourceContext( 62 static MediaStreamManager* GetForResourceContext(
65 content::ResourceContext* resource_context, 63 content::ResourceContext* resource_context);
66 media::AudioManager* audio_manager);
67 64
68 explicit MediaStreamManager(media::AudioManager* audio_manager); 65 MediaStreamManager();
66
69 virtual ~MediaStreamManager(); 67 virtual ~MediaStreamManager();
70 68
71 // Used to access VideoCaptureManager. 69 // Used to access VideoCaptureManager.
72 VideoCaptureManager* video_capture_manager(); 70 VideoCaptureManager* video_capture_manager();
73 71
74 // Used to access AudioInputDeviceManager. 72 // Used to access AudioInputDeviceManager.
75 AudioInputDeviceManager* audio_input_device_manager(); 73 AudioInputDeviceManager* audio_input_device_manager();
76 74
77 // GenerateStream opens new media devices according to |components|. The 75 // GenerateStream opens new media devices according to |components|. The
78 // request is identified using |label|, which is pointing to an already 76 // request is identified using |label|, which is pointing to an already
(...skipping 46 matching lines...) Expand 10 before | Expand all | Expand 10 after
125 123
126 // Implements SettingsRequester. 124 // Implements SettingsRequester.
127 virtual void DevicesAccepted(const std::string& label, 125 virtual void DevicesAccepted(const std::string& label,
128 const StreamDeviceInfoArray& devices) OVERRIDE; 126 const StreamDeviceInfoArray& devices) OVERRIDE;
129 virtual void SettingsError(const std::string& label) OVERRIDE; 127 virtual void SettingsError(const std::string& label) OVERRIDE;
130 128
131 // Used by unit test to make sure fake devices are used instead of a real 129 // Used by unit test to make sure fake devices are used instead of a real
132 // devices, which is needed for server based testing. 130 // devices, which is needed for server based testing.
133 void UseFakeDevice(); 131 void UseFakeDevice();
134 132
133 scoped_refptr<base::MessageLoopProxy> GetMessageLoop();
134
135 private: 135 private:
136 // Contains all data needed to keep track of requests. 136 // Contains all data needed to keep track of requests.
137 struct DeviceRequest; 137 struct DeviceRequest;
138 138
139 // Helpers for signaling the media observer that new capture devices are 139 // Helpers for signaling the media observer that new capture devices are
140 // opened/closed. 140 // opened/closed.
141 void NotifyObserverDevicesOpened(DeviceRequest* request); 141 void NotifyObserverDevicesOpened(DeviceRequest* request);
142 void NotifyObserverDevicesClosed(DeviceRequest* request); 142 void NotifyObserverDevicesClosed(DeviceRequest* request);
143 void DevicesFromRequest(DeviceRequest* request, 143 void DevicesFromRequest(DeviceRequest* request,
144 content::MediaStreamDevices* devices); 144 content::MediaStreamDevices* devices);
145 145
146 // Helpers. 146 // Helpers.
147 bool RequestDone(const MediaStreamManager::DeviceRequest& request) const; 147 bool RequestDone(const MediaStreamManager::DeviceRequest& request) const;
148 MediaStreamProvider* GetDeviceManager(MediaStreamType stream_type); 148 MediaStreamProvider* GetDeviceManager(MediaStreamType stream_type);
149 void StartEnumeration(DeviceRequest* new_request, 149 void StartEnumeration(DeviceRequest* new_request,
150 std::string* label); 150 std::string* label);
151 151
152 // Helper to ensure the device thread before passing to device managers.
153 void EnsureDeviceThread();
154
155 // Device thread shared by VideoCaptureManager and AudioInputDeviceManager.
156 scoped_ptr<base::Thread> device_thread_;
157
152 scoped_ptr<MediaStreamDeviceSettings> device_settings_; 158 scoped_ptr<MediaStreamDeviceSettings> device_settings_;
153 scoped_refptr<VideoCaptureManager> video_capture_manager_; 159 scoped_refptr<VideoCaptureManager> video_capture_manager_;
154 scoped_refptr<AudioInputDeviceManager> audio_input_device_manager_; 160 scoped_refptr<AudioInputDeviceManager> audio_input_device_manager_;
155 161
156 // Keeps track of device types currently being enumerated to not enumerate 162 // Keeps track of device types currently being enumerated to not enumerate
157 // when not necessary. 163 // when not necessary.
158 std::vector<bool> enumeration_in_progress_; 164 std::vector<bool> enumeration_in_progress_;
159 165
160 // All non-closed request. 166 // All non-closed request.
161 typedef std::map<std::string, DeviceRequest> DeviceRequests; 167 typedef std::map<std::string, DeviceRequest> DeviceRequests;
162 DeviceRequests requests_; 168 DeviceRequests requests_;
163 media::AudioManager* audio_manager_;
164 169
165 DISALLOW_COPY_AND_ASSIGN(MediaStreamManager); 170 DISALLOW_COPY_AND_ASSIGN(MediaStreamManager);
166 }; 171 };
167 172
168 } // namespace media_stream 173 } // namespace media_stream
169 174
170 #endif // CONTENT_BROWSER_RENDERER_HOST_MEDIA_MEDIA_STREAM_MANAGER_H_ 175 #endif // CONTENT_BROWSER_RENDERER_HOST_MEDIA_MEDIA_STREAM_MANAGER_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698