Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Issue 10662010: Use rsync to copy android testing directories (Closed)

Created:
8 years, 6 months ago by Isaac (away)
Modified:
8 years, 5 months ago
Reviewers:
John Grabowski, nilesh
CC:
chromium-reviews
Visibility:
Public.

Description

Use rsync to copy android testing directories - excluding .svn directories, which were being pushed onto phones - should also allow us to avoid unnecessary io pylint cleanup of this file BUG= TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=144392

Patch Set 1 #

Patch Set 2 : pylint cleanup #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : #

Patch Set 7 : #

Total comments: 1

Patch Set 8 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -41 lines) Patch
M testing/android/generate_native_test.py View 1 2 3 4 5 6 7 9 chunks +31 lines, -41 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Isaac (away)
8 years, 6 months ago (2012-06-24 19:42:42 UTC) #1
Isaac (away)
http://codereview.chromium.org/10662010/diff/12001/testing/android/generate_native_test.py File testing/android/generate_native_test.py (right): http://codereview.chromium.org/10662010/diff/12001/testing/android/generate_native_test.py#newcode90 testing/android/generate_native_test.py:90: logging.info(cmd_helper.GetCmdOutput( Note the --delete flag might be too strong ...
8 years, 6 months ago (2012-06-24 20:08:06 UTC) #2
John Grabowski
LGTM
8 years, 6 months ago (2012-06-26 00:02:39 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ilevy@chromium.org/10662010/14001
8 years, 5 months ago (2012-06-27 03:00:43 UTC) #4
commit-bot: I haz the power
8 years, 5 months ago (2012-06-27 03:53:56 UTC) #5
Change committed as 144392

Powered by Google App Engine
This is Rietveld 408576698