Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1174)

Unified Diff: chrome/browser/nacl_host/pnacl_file_host_unittest.cc

Issue 10662006: Add a NaCl-Private interface for opening files in DIR_PNACL_COMPONENT. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: do not run test when disable_nacl=1 Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/nacl_host/pnacl_file_host_unittest.cc
diff --git a/chrome/browser/nacl_host/pnacl_file_host_unittest.cc b/chrome/browser/nacl_host/pnacl_file_host_unittest.cc
new file mode 100644
index 0000000000000000000000000000000000000000..944a2ed405617d90ebea04fe4683fc971d1a65f3
--- /dev/null
+++ b/chrome/browser/nacl_host/pnacl_file_host_unittest.cc
@@ -0,0 +1,49 @@
+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/nacl_host/pnacl_file_host.h"
+
+#include "base/basictypes.h"
+#include "base/file_path.h"
+#include "base/path_service.h"
+#include "chrome/common/chrome_paths.h"
+
+#include "testing/gtest/include/gtest/gtest.h"
+
+using pnacl_file_host::PnaclCanOpenFile;
+
+// Try to pass a few funny filenames with a dummy pnacl directory set.
+TEST(PnaclFileHostTest, TestFilenamesWithPnaclPath) {
+ FilePath kDummyPnaclPath(FILE_PATH_LITERAL("dummy_pnacl_path"));
+ ASSERT_TRUE(PathService::Override(chrome::DIR_PNACL_COMPONENT,
+ kDummyPnaclPath));
+ ASSERT_TRUE(PathService::Get(chrome::DIR_PNACL_COMPONENT,
+ &kDummyPnaclPath));
+ FilePath out_path;
+ EXPECT_TRUE(PnaclCanOpenFile("manifest.json", &out_path));
+ FilePath expected_path = kDummyPnaclPath.Append(
+ FILE_PATH_LITERAL("manifest.json"));
+ EXPECT_EQ(out_path, expected_path);
+
+ EXPECT_TRUE(PnaclCanOpenFile("x86-32/llc", &out_path));
+ expected_path = kDummyPnaclPath.Append(FILE_PATH_LITERAL("x86-32/llc"));
+ EXPECT_EQ(out_path, expected_path);
+
+ EXPECT_FALSE(PnaclCanOpenFile("", &out_path));
+ EXPECT_FALSE(PnaclCanOpenFile(".", &out_path));
+ EXPECT_FALSE(PnaclCanOpenFile("..", &out_path));
+#if defined(OS_WIN)
+ EXPECT_FALSE(PnaclCanOpenFile("..\\llc", &out_path));
+ EXPECT_FALSE(PnaclCanOpenFile("%SystemRoot%", &out_path));
+ EXPECT_FALSE(PnaclCanOpenFile("%SystemRoot%\\explorer.exe", &out_path));
+#else
+ EXPECT_FALSE(PnaclCanOpenFile("../llc", &out_path));
+ EXPECT_FALSE(PnaclCanOpenFile("/bin/sh", &out_path));
+ EXPECT_FALSE(PnaclCanOpenFile("$HOME", &out_path));
+ EXPECT_FALSE(PnaclCanOpenFile("$HOME/.bashrc", &out_path));
+#endif
+
+ const char non_ascii[] = "\xff\xfe";
+ EXPECT_FALSE(PnaclCanOpenFile(non_ascii, &out_path));
+}
« no previous file with comments | « chrome/browser/nacl_host/pnacl_file_host.cc ('k') | chrome/browser/renderer_host/chrome_render_message_filter.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698