Issue 10662: Fixes text field background when disabled/read-only to better match...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10662: Fixes text field background when disabled/read-only to better match... (Closed)

Created:
12 years, 1 month ago by sky

Modified:
9 years, 7 months ago

Reviewers:
Finnur

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Fixes text field background when disabled/read-only to better match how Windows looks. This also changes SetEnabled not to adjust read_only_ state. That SetEnabled invoked SetReadOnly is just wrong, the two don't have to be the same. BUG=1218491 TEST=bring up the keyword editor and double click on one of the default search engines, make sure the background of the text field looks disabled. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=5317

Patch Set 1 #

Created: 12 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+40 lines, -18 lines)			Patch
	M	chrome/views/text_field.h	View		2 chunks	+4 lines, -0 lines	0 comments	Download
	M	chrome/views/text_field.cc	View		12 chunks	+36 lines, -18 lines	2 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Finnur

12 years, 1 month ago (2008-11-12 22:57:39 UTC) #2

LGTM, 2 nits:

http://codereview.chromium.org/10662/diff/1/3
File chrome/views/text_field.cc (right):

http://codereview.chromium.org/10662/diff/1/3#newcode14
Line 14: #include "base/gfx/skia_utils.h"
s is after n in the alphabet. :)

http://codereview.chromium.org/10662/diff/1/3#newcode204
Line 204: DISALLOW_EVIL_CONSTRUCTORS(Edit);
DISALLOW_COPY_AND_ASSIGN. Sorry, didn't mean to shout at you. :)

Expand Messages | Collapse Messages