Move chrome.appWindow to chrome.app.window.

tools/json_schema_compiler/schema_bundle_generator.py

 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import code
 import cpp_util
 
 import json
 import os
 import re
 
 # TODO(miket/asargent) - parameterize this.
 SOURCE_BASE_PATH = 'chrome/common/extensions/api'
 
+
+def CapitalizeFirstLetter(value):
+  return value[0].capitalize() + value[1:]
+
 class SchemaBundleGenerator(object):
   """This class contains methods to generate code based on multiple schemas.
   """
 
   def __init__(self, model, api_defs, cpp_type_generator):
     self._model = model
     self._api_defs = api_defs
     self._cpp_type_generator = cpp_type_generator
 
   def GenerateHeader(self, file_base, body_code):
@@ skipping 37 matching lines @@
 
     c.Concat(self._cpp_type_generator.GetRootNamespaceStart())
     for namespace in self._model.namespaces.values():
       c.Append("// TODO(miket): emit code for %s" % (namespace.unix_name))
     c.Append()
     c.Concat(self.GenerateFunctionRegistry())
     c.Concat(self._cpp_type_generator.GetRootNamespaceEnd())
     c.Append()
     return self.GenerateHeader('generated_api', c)
 
-  def CapitalizeFirstLetter(self, value):
-    return value[0].capitalize() + value[1:]
-
   def GenerateFunctionRegistry(self):
     c = code.Code()
     c.Sblock("class GeneratedFunctionRegistry {")
     c.Append("public:")
     c.Sblock("static void RegisterAll(ExtensionFunctionRegistry* registry) {")
     for namespace in self._model.namespaces.values():
       for function in namespace.functions.values():
         if function.nocompile:
           continue
-        namespace_name = self.CapitalizeFirstLetter(namespace.name.replace(
-            "experimental.", ""))
-        function_name = namespace_name + self.CapitalizeFirstLetter(
-            function.name)
+
+        # Transform a fully qualified function name like foo.bar.baz into

[Mihai Parparita -not on Chrome, 2012/06/26 05:19:16]

Move into a function so that it can be unit tested?

[asargent_no_longer_on_chrome, 2012/07/20 00:11:46]

Done.

[Mihai Parparita -not on Chrome, 2012/07/20 00:36:52]

Not seeing this change in the current patch.

+        # FooBarBaz, stripping any leading 'Experimental' prefix.
+        parts = []
+        function_name = namespace.name + "." + function.name
+        for part in function_name.split("."):
+          parts.append(CapitalizeFirstLetter(part))
+        if parts[0] == "Experimental":
+          del parts[0]
+        function_name = "".join(parts)
+
         c.Append("registry->RegisterFunction<%sFunction>();" % (
             function_name))
     c.Eblock("}")
     c.Eblock("};")
     c.Append()
     return c
 
   def GenerateSchemasHeader(self):
     """Generates a code.Code object for the generated schemas .h file"""
     c = code.Code()
@@ skipping 39 matching lines @@
       for index, line in enumerate(lines):
         line = '    "%s"' % line
         if index == len(lines) - 1:
           line += ';'
         c.Append(line)
     c.Eblock('}')
     c.Append()
     c.Concat(self._cpp_type_generator.GetRootNamespaceEnd())
     c.Append()
     return c