chrome/test/data/extensions/platform_apps/iframes/manifest.json - Issue 10659021: Move chrome.appWindow to chrome.app.window.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/test/data/extensions/platform_apps/iframes/manifest.json

Issue 10659021: Move chrome.appWindow to chrome.app.window. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: rebased Created 8 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« chrome/test/data/extensions/platform_apps/browser_tag_isolation/test.js ('K') | « chrome/test/data/extensions/platform_apps/context_menu/test.js ('k') | chrome/test/data/extensions/platform_apps/iframes/test.js » ('j') | tools/json_schema_compiler/schema_bundle_generator.py » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 {	1 {

2 "name": "Platform App Test: local iframes are allowed",	2 "name": "Platform App Test: local iframes are allowed",

3 "version": "1",	3 "version": "1",

4 "manifest_version": 2,	4 "manifest_version": 2,

5 "permissions": [	5 "permissions": [

6 "experimental",	6 "experimental",

7 "appWindow"	7 "app.window"
	not at google - send to devlin 2012/07/18 04:27:37 delete? delete? asargent_no_longer_on_chrome 2012/07/20 00:11:47 I think we actually still want it as an explicit p Show quoted text On 2012/07/18 04:27:37, kalman wrote: > delete? I think we actually still want it as an explicit permission - Mihai, was this your intention? Mihai Parparita -not on Chrome 2012/07/20 00:21:43 Jeremy made it so that apps don't need to declare Show quoted text On 2012/07/20 00:11:47, Antony Sargent wrote: > On 2012/07/18 04:27:37, kalman wrote: > > delete? > > I think we actually still want it as an explicit permission - Mihai, was this > your intention? Jeremy made it so that apps don't need to declare it in the manifest (http://crrev.com/144056, redone as http://crrev.com/144370). There's no harm in including it, but it's not necessary.
8 ],	8 ],

9 "app": {	9 "app": {

10 "background": {	10 "background": {

11 "scripts": ["test.js"]	11 "scripts": ["test.js"]

12 }	12 }

13 },	13 },

14 // Attempt to specify a Content Security Policy that is more relaxed than the	14 // Attempt to specify a Content Security Policy that is more relaxed than the

15 // default (would allow remote iframes). It should be ignored.	15 // default (would allow remote iframes). It should be ignored.

16 "content_security_policy": "script-src 'self'; object-src 'self'"	16 "content_security_policy": "script-src 'self'; object-src 'self'"

17 }	17 }

OLD	NEW