Silence adb command output by default

build/android/android_commands.py

 #!/usr/bin/env python
 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Provides an interface to communicate with the device via the adb command.
 
 Assumes adb binary is currently on system path.
 
 Usage:
@@ skipping 448 matching lines @@
     # /foo/bar:
     # -rw-r----- 1 user group   102 2011-05-12 12:29:54.131623387 +0100 baz.txt
     re_file = re.compile('^-(?P<perms>[^\s]+)\s+'
                          '(?P<user>[^\s]+)\s+'
                          '(?P<group>[^\s]+)\s+'
                          '(?P<size>[^\s]+)\s+'
                          '(?P<date>[^\s]+)\s+'
                          '(?P<time>[^\s]+)\s+'
                          '(?P<filename>[^\s]+)$')
     return _GetFilesFromRecursiveLsOutput(
-        path, self.RunShellCommand('ls -lR %s' % path), re_file,
-        self.RunShellCommand('date +%z')[0])
+        path, self.RunShellCommand('ls -lR %s' % path, log_result=False),

[bulach, 2012/06/25 09:47:51]

long story super short: in the past, we had various problems that were only
caught with the logs. things like parsing the output of a given command not
being robust enough to deal with unexpected output or errors, etc..

I think we're now in a much better situation, and overall all the parsers and
callers for RunShellCommand are much more reliable...

my suggestion would be: instead of sprinkling these with log_result=False, let's
make the default False, and then only the lines that actually need, would turn
it on...

since this is such a high impact change though, I'd suggest doing it downstream
first, wait a few days, then upstream..
(and yes, I know it's locked down :) but unfortunately we don't have yet the
same coverage level yet for such broad changes upstream first..).

wdyt?

+        re_file, self.RunShellCommand('date +%z')[0])
 
   def SetupPerformanceTest(self):
     """Sets up performance tests."""
     # Disable CPU scaling to reduce noise in tests
     if not self._original_governor:
       self._original_governor = self.RunShellCommand('cat ' + SCALING_GOVERNOR)
       self.RunShellCommand('echo performance > ' + SCALING_GOVERNOR)
     self.DropRamCaches()
 
   def TearDownPerformanceTest(self):
@@ skipping 290 matching lines @@
   options, args = option_parser.parse_args(argv)
 
   commands = AndroidCommands(wait_for_pm=options.wait_for_pm)
   if options.set_asserts != None:
     if commands.SetJavaAssertsEnabled(options.set_asserts):
       commands.Reboot(full_reboot=False)
 
 
 if __name__ == '__main__':
   main(sys.argv)