[sync] Automatic bootstrapping of Sync on Win 8 from cached credentials

chrome/browser/profiles/profile_impl.cc

Index: chrome/browser/profiles/profile_impl.cc
diff --git a/chrome/browser/profiles/profile_impl.cc b/chrome/browser/profiles/profile_impl.cc
index 7a5199b570866ce71fbd6ab0f9d35ce0783ed4e2..504b1bb0fe44087c5c0dffdec96bd608443417f8 100644
--- a/chrome/browser/profiles/profile_impl.cc
+++ b/chrome/browser/profiles/profile_impl.cc
@@ -67,6 +67,9 @@
 #include "chrome/browser/search_engines/template_url_fetcher.h"
 #include "chrome/browser/sessions/session_service_factory.h"
 #include "chrome/browser/speech/chrome_speech_recognition_preferences.h"
+#if defined(OS_WIN)
+#include "chrome/browser/sync/credential_cache_service_factory_win.h"
+#endif
 #include "chrome/browser/sync/profile_sync_service_factory.h"
 #include "chrome/browser/ui/startup/startup_browser_creator.h"
 #include "chrome/browser/ui/webui/extensions/extension_icon_source.h"
@@ -855,6 +858,10 @@ void ProfileImpl::Observe(int type,
     case chrome::NOTIFICATION_BOOKMARK_MODEL_LOADED:
       // Causes lazy-load if sync is enabled.
       ProfileSyncServiceFactory::GetInstance()->GetForProfile(this);
+#if defined(OS_WIN)
+      // Causes lazy-load on Windows 8 if sync is enabled.
+      syncer::CredentialCacheServiceFactory::GetInstance()->GetForProfile(this);

[Andrew T Wilson (Slow), 2012/07/24 20:55:29]

I think the cleaner way to do this is to have CredentialCacheServiceFactory
return true from ServiceIsCreatedWithProfile() - then it just gets created on
startup. 

[Raghu Simha, 2012/07/24 22:17:35]

Done.

+#endif  // OS_WIN
       registrar_.Remove(this, chrome::NOTIFICATION_BOOKMARK_MODEL_LOADED,
                         content::Source<Profile>(this));
       break;