[sync] Automatic bootstrapping of Sync on Win 8 from cached credentials

chrome/browser/sync/profile_sync_service.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/sync/profile_sync_service.h"
 
 #include <cstddef>
 #include <map>
 #include <set>
 #include <utility>
 
 #include "base/basictypes.h"
 #include "base/bind.h"
 #include "base/callback.h"
 #include "base/command_line.h"
 #include "base/compiler_specific.h"
 #include "base/logging.h"
 #include "base/memory/ref_counted.h"
 #include "base/message_loop.h"
 #include "base/metrics/histogram.h"
 #include "base/string16.h"
 #include "base/stringprintf.h"
 #include "base/threading/thread_restrictions.h"
+#if defined(OS_WIN)
+#include "base/win/windows_version.h"
+#endif
 #include "chrome/browser/about_flags.h"
 #include "chrome/browser/browser_process.h"
 #include "chrome/browser/defaults.h"
 #include "chrome/browser/net/chrome_cookie_notification_details.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/signin/signin_manager.h"
 #include "chrome/browser/signin/signin_manager_factory.h"
 #include "chrome/browser/signin/token_service.h"
 #include "chrome/browser/signin/token_service_factory.h"
 #include "chrome/browser/sync/backend_migrator.h"
+#include "chrome/browser/sync/credential_cache_service_factory_win.h"
+#include "chrome/browser/sync/credential_cache_service_win.h"
 #include "chrome/browser/sync/glue/change_processor.h"
 #include "chrome/browser/sync/glue/chrome_encryptor.h"
 #include "chrome/browser/sync/glue/chrome_report_unrecoverable_error.h"
 #include "chrome/browser/sync/glue/data_type_controller.h"
 #include "chrome/browser/sync/glue/session_data_type_controller.h"
 #include "chrome/browser/sync/glue/session_model_associator.h"
 #include "chrome/browser/sync/glue/typed_url_data_type_controller.h"
 #include "chrome/browser/sync/profile_sync_components_factory_impl.h"
 #include "chrome/browser/sync/sync_global_error.h"
 #include "chrome/browser/sync/user_selectable_sync_type.h"
@@ skipping 18 matching lines @@
 #include "sync/internal_api/public/util/sync_string_conversions.h"
 #include "sync/js/js_arg_list.h"
 #include "sync/js/js_event_details.h"
 #include "sync/util/cryptographer.h"
 #include "ui/base/l10n/l10n_util.h"
 
 using browser_sync::ChangeProcessor;
 using browser_sync::DataTypeController;
 using browser_sync::DataTypeManager;
 using browser_sync::SyncBackendHost;
+using syncer::CredentialCacheService;
+using syncer::CredentialCacheServiceFactory;
 using syncer::ModelType;
 using syncer::ModelTypeSet;
 using syncer::JsBackend;
 using syncer::JsController;
 using syncer::JsEventDetails;
 using syncer::JsEventHandler;
 using syncer::ModelSafeRoutingInfo;
 using syncer::SyncCredentials;
 using syncer::SyncProtocolError;
 using syncer::WeakHandle;
@@ skipping 50 matching lines @@
       signin_(signin_manager),
       unrecoverable_error_reason_(ERROR_REASON_UNSET),
       weak_factory_(ALLOW_THIS_IN_INITIALIZER_LIST(this)),
       expect_sync_configuration_aborted_(false),
       encrypted_types_(syncer::Cryptographer::SensitiveTypes()),
       encrypt_everything_(false),
       encryption_pending_(false),
       auto_start_enabled_(start_behavior == AUTO_START),
       failed_datatypes_handler_(ALLOW_THIS_IN_INITIALIZER_LIST(this)),
       configure_status_(DataTypeManager::UNKNOWN),
-      setup_in_progress_(false) {
+      setup_in_progress_(false),
+      credential_cache_service_(NULL) {
 #if defined(OS_ANDROID)
   chrome::VersionInfo version_info;
   if (version_info.IsOfficialBuild()) {
     sync_service_url_ = GURL(kSyncServerUrl);
   }
 #else
   // By default, dev, canary, and unbranded Chromium users will go to the
   // development servers. Development servers have more features than standard
   // sync servers. Users with officially-branded Chrome stable and beta builds
   // will go to the standard sync servers.
@@ skipping 45 matching lines @@
     return;
   }
 
   RegisterAuthNotifications();
 
   if (!HasSyncSetupCompleted() || signin_->GetAuthenticatedUsername().empty()) {
     // Clean up in case of previous crash / setup abort / signout.
     DisableForUser();
   }
 
+#if defined(OS_WIN)
+  // Initialize the CredentialCacheService for the default profile on Windows 8.
+  if (base::win::GetVersion() >= base::win::VERSION_WIN8 &&

[Andrew T Wilson (Slow), 2012/07/24 18:00:33]

I guess I still don't understand why PSS needs to do all this stuff - why
doesn't CredentialCacheService handle all of this (logging in the user, etc)
without requiring Sync to explicitly force its creation, and explicitly call
LookForCachedCredentialsInAlternateProfile()?

You now have this explicit dependency between PSS and CCS, and seemingly the
only reason is so that the CCS doesn't have to check IsStartSuppressed(). I
think this change is much cleaner if the CCS self initializes and doesn't
require PSS to call into it.

[Raghu Simha, 2012/07/24 20:45:04]

I see what you mean. I originally coupled PSS and CCS because the primary
purpose of CCS was to enable sync if possible. I've moved the "should we
initialize CCS" logic to within CCS. We now (lazily) instantiate CCS at the same
spot where PSS is instantiated, in profile_impl.cc.

+      CredentialCacheService::IsDefaultProfileDir(profile()->GetPath()) &&
+      !sync_prefs_.IsStartSuppressed()) {
+    credential_cache_service_ =
+        CredentialCacheServiceFactory::GetInstance()->GetForProfile(profile_);
+  }
+#endif  // OS_WIN
+
   TryStart();
 }
 
 void ProfileSyncService::TryStart() {
-  if (!IsSyncEnabledAndLoggedIn())
+  if (!IsSyncEnabledAndLoggedIn()) {
+#if defined(OS_WIN)
+    if (credential_cache_service_)
+      credential_cache_service_->LookForCachedCredentialsInAlternateProfile();
+#endif  // OS_WIN
     return;
+  }
+
   TokenService* token_service = TokenServiceFactory::GetForProfile(profile_);
   if (!token_service)
     return;
   // Don't start the backend if the token service hasn't finished loading tokens
   // yet (if the backend is started before the sync token has been loaded,
   // GetCredentials() will return bogus credentials). On auto_start platforms
   // (like ChromeOS) we don't start sync until tokens are loaded, because the
   // user can be "signed in" on those platforms long before the tokens get
   // loaded, and we don't want to generate spurious auth errors.
   if (IsSyncTokenAvailable() ||
@@ skipping 1539 matching lines @@
   // See http://stackoverflow.com/questions/6224121/is-new-this-myclass-undefined-behaviour-after-directly-calling-the-destru.
   ProfileSyncService* old_this = this;
   this->~ProfileSyncService();
   new(old_this) ProfileSyncService(
       new ProfileSyncComponentsFactoryImpl(profile,
                                            CommandLine::ForCurrentProcess()),
       profile,
       signin,
       behavior);
 }