Add Linux lighttpd for running LayoutTests on Linux.

Add Linux lighttpd for running LayoutTests on Linux.

Updated to use system lighttpd and php-cgi. This is based on the Hardy packages and file layout. YMMV with other distros.

BUG=4281

[dank, 2008-11-12 21:19:46]

Checking in binaries is worse on Linux than on Mac or Windows
because Linux is nowhere near as ABI-stable.

Can't we check in the source and get scons to build it somehow?
That'd be way nicer.

[tony, 2008-11-12 21:33:19]

Alternately, can we just apt-get the package?

On 2008/11/12 21:19:46, dank wrote:
> Checking in binaries is worse on Linux than on Mac or Windows
> because Linux is nowhere near as ABI-stable.
> 
> Can't we check in the source and get scons to build it somehow?
> That'd be way nicer.

[Michael Moss, 2008-11-13 18:09:59]

I'll try to rework this to build with scons. If anybody needs Linux LayoutTests
sooner, let me know and I can submit this as an interim solution (with Issue
10413, it gets LayoutTests limping along on Linux).

[Michael Moss, 2008-11-17 18:17:04]

I'd like to submit these binaries so people can start working on Linux layout
tests sooner. I'll come back to the source-built solution after we have the
layout tests running (i.e. rest of test_shell ported). I've added bug
http://code.google.com/p/chromium/issues/detail?id=4501 to track this clean-up.

[tony, 2008-11-17 19:18:55]

lighttpd isn't required for running the layout tests, it's only required for
running the http layout tests.  The test shell runner accepts a command line
path glob for which tests to run and if none of the tests require http, it
shouldn't try to start lighttpd.  E.g., "run_webkit_tests.sh LayoutTests/fast/"
should try to start lighttpd.

On 2008/11/17 18:17:04, mmoss wrote:
> I'd like to submit these binaries so people can start working on Linux layout
> tests sooner. I'll come back to the source-built solution after we have the
> layout tests running (i.e. rest of test_shell ported). I've added bug
> http://code.google.com/p/chromium/issues/detail?id=4501 to track this
clean-up.

[Michael Moss, 2008-11-17 19:39:31]

On 2008/11/17 19:18:55, tony wrote:
> lighttpd isn't required for running the layout tests, it's only required for
> running the http layout tests.

Yes, of course. I should have specified "all layout tests". So do you mean you
are more interested in seeing the build reworked for lighttpd/php than in making
all layout tests available now, or was that just an informational response?

[tony, 2008-11-17 20:21:19]

On 2008/11/17 19:39:31, mmoss wrote:
> Yes, of course. I should have specified "all layout tests". So do you mean you
> are more interested in seeing the build reworked for lighttpd/php than in
making
> all layout tests available now, or was that just an informational response?

Yes, I think we should just rework the build for lighttpd/php rather than
checking in binaries on linux.  I don't think this is blocking our progress
right now (we can even update the test runner to skip http tests on linux until
this is working).

[Michael Moss, 2008-11-17 23:50:57]

I'm going to take a closer look at using system packages. Pink indicated it
could be a problem because we need specific compile-time flags to make lighttpd
and php-cgi work together, but that might have been overly cautious, and the
Hardy might have the necessary options (of course, this doesn't say anything
about other distros). One thing I'm not sure about though is, where is php-cgi
actually used? Anybody know? Looking through the code, the only PHP file I saw
was third_party/WebKit/WebCore/manual-tests/timeout-test.php. Is that needed for
LayoutTests? If not, is there some other reason we need PHP support?

[Evan Martin, 2008-11-18 00:07:29]

I'd be pretty surprised if hardy didn't support PHP out of the box.

In my order of preference:
1) use system lighttpd
2) use checked-in lighttpd
3) distant third: use scons
our build is insane enough already, requiring extra code for a python http
server as well -- please try to avoid dragging more stuff in.  :)

[tony, 2008-11-18 00:13:43]

You need to checkout the LayoutTests from svn.webkit.org.  I see 35 files in
webkit/data/layout_tests/LayoutTests/http that end in .php.


On 2008/11/17 23:50:57, mmoss wrote:
> I'm going to take a closer look at using system packages. Pink indicated it
> could be a problem because we need specific compile-time flags to make
lighttpd
> and php-cgi work together, but that might have been overly cautious, and the
> Hardy might have the necessary options (of course, this doesn't say anything
> about other distros). One thing I'm not sure about though is, where is php-cgi
> actually used? Anybody know? Looking through the code, the only PHP file I saw
> was third_party/WebKit/WebCore/manual-tests/timeout-test.php. Is that needed
for
> LayoutTests? If not, is there some other reason we need PHP support?

[Michael Moss, 2008-11-18 00:36:27]

Updated to use system binaries. This seems to work OK with a sample of http and
php tests on gHardy.

[Evan Martin, 2008-11-18 00:39:40]

Nice!  LGTM

[Evan Martin, 2008-11-18 00:40:07]

Oh, and please update the build instructions too: 
http://code.google.com/p/chromium/wiki/LinuxBuildInstructions

[tony, 2008-11-18 06:38:09]

LGTM2.  It would be nice if we gave a nice error message if /usr/sbin/lighttpd
didn't exist (e.g., Please install lighttpd using "sudo apt-get install lighttpd
php5cgi").

On 2008/11/18 00:40:07, Evan Martin wrote:
> Oh, and please update the build instructions too: 
> http://code.google.com/p/chromium/wiki/LinuxBuildInstructions

[Michael Moss, 2008-11-18 20:31:25]

Added friendly error message. Not sure if we like sys.exit(), but raising an
exception makes a messy backtrace, which tends to hide the useful message.

[tony, 2008-11-18 20:49:25]

LGTM

http://codereview.chromium.org/10653/diff/607/413
File webkit/tools/layout_tests/layout_package/platform_utils_linux.py (right):

http://codereview.chromium.org/10653/diff/607/413#newcode100
Line 100: print 'Please install lighttpd/php using "sudo apt-get install
lighttpd php5cgi"'
Nit: 80 col (see two others below).