chrome/browser/resources/chrome_app/manifest.json - Issue 10652003: chromeos: Make Chrome app a real app.

Side by Side Diff: chrome/browser/resources/chrome_app/manifest.json

Issue 10652003: chromeos: Make Chrome app a real app. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: no context menu for chrome app Created 8 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« chrome/browser/extensions/component_loader.h ('K') | « chrome/browser/extensions/image_loading_tracker.cc ('k') | chrome/browser/ui/views/ash/app_list/apps_model_builder.cc » ('j') | chrome/common/extensions/extension_constants.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 {

	2 "key": "MIGfMA0GCSqGSIb3DQEBAQUAA4GNADCBiQKBgQDNuYLEQ1QPMcc5HfWI/9jiEf6FdJWqEt gRmIeI7qtjPLBM5oje+Ny2E2mTAhou5qdJiO2CHWdU1DQXY2F7Zu2gZaKZgHLfK4WimHxUT5Xd9/aro/ R9PCzjguM1BLusiWYc9xlj1IsZpyiN1hcjU7SCnBhv1feQlv2WSB5KRiXwhQIDAQAB",
	asargent_no_longer_on_chrome 2012/06/21 22:45:08 Looks like you just copied this value from the web Looks like you just copied this value from the webstore app - for chrome extensions/apps, the key is actually per-item, not a certificate used to sign multiple different items. So you should generate a new random key to use. To do this, just create a dummy empty extension, use the chrome://extensions page to pack it into a .crx file, install that, find it's id on the chrome://extensions page, and then look in your <user profile dir>/Preferences file to find the entry for that extension and copy the key value out. Also that id should be the value that you use for the kChromeAppId constant. (Sorry this is such a hassle - we don't need to do it very often or otherwise we'd make it easier). xiyuan 2012/06/21 23:19:44 Actually, this is a different key from webstore. : Show quoted text On 2012/06/21 22:45:08, Antony Sargent wrote: > Looks like you just copied this value from the webstore app - for chrome > extensions/apps, the key is actually per-item, not a certificate used to sign > multiple different items. So you should generate a new random key to use. To do > this, just create a dummy empty extension, use the chrome://extensions page to > pack it into a .crx file, install that, find it's id on the chrome://extensions > page, and then look in your <user profile dir>/Preferences file to find the > entry for that extension and copy the key value out. Also that id should be the > value that you use for the kChromeAppId constant. > > (Sorry this is such a hassle - we don't need to do it very often or otherwise > we'd make it easier). > Actually, this is a different key from webstore. :) I followed your steps to get this key created. It just happened to be the same on the first 39 chars. asargent_no_longer_on_chrome 2012/06/22 23:25:38 The last 7 characters too! That defeated my typica Show quoted text On 2012/06/21 23:19:44, xiyuan wrote: > On 2012/06/21 22:45:08, Antony Sargent wrote: > > Looks like you just copied this value from the webstore app - for chrome > > extensions/apps, the key is actually per-item, not a certificate used to sign > > multiple different items. So you should generate a new random key to use. To > do > > this, just create a dummy empty extension, use the chrome://extensions page to > > pack it into a .crx file, install that, find it's id on the > chrome://extensions > > page, and then look in your <user profile dir>/Preferences file to find the > > entry for that extension and copy the key value out. Also that id should be > the > > value that you use for the kChromeAppId constant. > > > > (Sorry this is such a hassle - we don't need to do it very often or otherwise > > we'd make it easier). > > > > Actually, this is a different key from webstore. :) I followed your steps to get > this key created. It just happened to be the same on the first 39 chars. The last 7 characters too! That defeated my typical "eyeball the difference between two long hashes by looking at the first few and last few chars" algorithm. =)
	3 "name": "Chrome",

	4 "version": "0.1",

	5 "description": "Chrome as an app",

	6 "app": {

	7 "launch": {

	8 "web_url": "http://www.google.com/chrome"
	asargent_no_longer_on_chrome 2012/06/21 22:45:08 Instead of http://www.google.com/chrome, can we ma Instead of http://www.google.com/chrome, can we make the url be something like http://DUMMY-VALUE or http://THIS-WILL-BE-REPLACED? Also can you please add a comment here that mentions that this will be changed by special case to become chrome://newtab? (Our json parser supports c-style comments with a leading // delimiter). xiyuan 2012/06/21 23:19:44 Done. Show quoted text On 2012/06/21 22:45:08, Antony Sargent wrote: > Instead of http://www.google.com/chrome, can we make the url be something like > http://DUMMY-VALUE or http://THIS-WILL-BE-REPLACED? > > Also can you please add a comment here that mentions that this will be changed > by special case to become chrome://newtab? (Our json parser supports c-style > comments with a leading // delimiter). > Done.
	9 }

	10 }

	11 }

OLD	NEW